-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add both uint64 and int64 to tlscommon types unpack methods #198
Add both uint64 and int64 to tlscommon types unpack methods #198
Conversation
Needs tests |
(no tests is why we didn't catch this initially) |
Not sure how the fleet-server is reading/unserializing the policies from es; the |
70c8f09
to
84e5935
Compare
@@ -173,3 +173,80 @@ func Test_ServerConfig_Repack(t *testing.T) { | |||
}) | |||
} | |||
} | |||
|
|||
func Test_ServerConfig_RepackJSON(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we encounter json serialization in the error we observed but i've added tests in case that is the issue.
I've also added Unpack unit tests to all the types
💚 Build Succeeded
History
|
What does this PR do?
Add
int64
support to unpack methods which only supporteduint64
Why is it important?
We see the error message
in our snapshots.
Checklist
Related issues