Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repack support for ServerConfig.ClientAuth #197

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

michel-laterman
Copy link
Contributor

What does this PR do?

Follow up to #196 to allow fleet-server to repack the ServerConfig struct.
Extend the ClientAuthType unpack method to allow integer values and repack support. Add unit tests to verify behaviour.

Why is it important?

output from policy in fleet-server needs to be able to merge structs

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

Related issues

Extend the ClientAuthType unpack method to allow integer values and
repack support. Add unit tests to verify behaviour.
@michel-laterman michel-laterman added enhancement New feature or request Team:Elastic-Agent Label for the Agent team labels Apr 11, 2024
@michel-laterman michel-laterman requested review from cmacknz and faec April 11, 2024 19:42
@michel-laterman michel-laterman requested a review from a team as a code owner April 11, 2024 19:42
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@michel-laterman michel-laterman merged commit 8fcae27 into elastic:main Apr 12, 2024
6 checks passed
@michel-laterman michel-laterman deleted the repack-server-config branch April 12, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants