Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace go-multierror with stdlib methods #164

Merged
merged 2 commits into from
Dec 6, 2023
Merged

refactor: replace go-multierror with stdlib methods #164

merged 2 commits into from
Dec 6, 2023

Conversation

kruskall
Copy link
Member

What does this PR do?

Replace multierror libs with stdlib methods

Why is it important?

Go 1.20 added support for wrapping multiple errors: https://tip.golang.org/doc/go1.20#errors

Drop unnecessary dependencies

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

Author's Checklist

  • [ ]

Related issues

@kruskall
refactor: replace go-multierror with stdlib methods
d23e398 
Go 1.20 added support for wrapping multiple errors.

Replace multierror libs with stdlib methods
@kruskall kruskall requested a review from a team as a code owner November 17, 2023 17:30
@kruskall kruskall requested review from ycombinator and faec and removed request for a team November 17, 2023 17:30
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Nov 18, 2023
cmacknz
cmacknz approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@cmacknz cmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kruskall kruskall merged commit 7f2c636 into elastic:main Dec 6, 2023
7 checks passed
@kruskall kruskall deleted the drop/multi-error branch December 6, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmacknz cmacknz cmacknz approved these changes

@ycombinator ycombinator Awaiting requested review from ycombinator ycombinator is a code owner automatically assigned from elastic/elastic-agent-data-plane

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees
No one assigned
Labels
Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kruskall @elasticmachine @cmacknz @pierrehilbert