Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BlockSelectors for level debug #125

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

belimawr
Copy link
Contributor

@belimawr belimawr commented May 23, 2023

What does this PR do?

This commit implements a block list of selectors for debug logging on logp.

Why is it important?

It allows us to drop logs from some very verbose debug loggers while still getting all the other debug logs. There are some situations where we know the verbose loggers we do not need, however we don't have a exhaustive list of all the loggers we do want debug logs, this PR aims to solve this problem.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.md

## Author's Checklist
## Related issues

@elasticmachine
Copy link
Collaborator

elasticmachine commented May 23, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-08T13:02:41.189+0000

  • Duration: 11 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 789
Skipped 11
Total 800

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@belimawr belimawr marked this pull request as ready for review June 8, 2023 07:43
@belimawr belimawr requested a review from a team as a code owner June 8, 2023 07:43
@belimawr belimawr requested review from cmacknz and leehinman and removed request for a team June 8, 2023 07:43
This commit implements a block list of selectors for debug logging on
`logp`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants