Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bot triggered PRs to run CI #103

Merged

Conversation

dliappis
Copy link
Contributor

This commit allows Buildkite run CI for bots generated by the dependabot and mergify bots, thus removing the need to manually allow execution with the trigger phrase.

This commit allows Buildkite run CI for bots generated by the
dependabot and mergify bots, thus removing the need to manually allow
execution with the trigger phrase.
@dliappis dliappis added the ci label Mar 14, 2024
@dliappis dliappis requested a review from mrodm March 14, 2024 15:03
@dliappis dliappis self-assigned this Mar 14, 2024
@dliappis dliappis requested a review from a team as a code owner March 14, 2024 15:03
@dliappis dliappis requested review from AndersonQ and pchila and removed request for a team March 14, 2024 15:03
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 14, 2024

💔 Build Failed

Failed CI Steps

History

cc @dliappis

Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dliappis
Copy link
Contributor Author

I will merge this now, despite the CI check failing with

# golang.org/x/tools/go/types/objectpath
/go/src/golang.org/x/tools/go/types/objectpath/objectpath.go:397:10: meth.Origin undefined (type *types.Func has no field or method Origin)
Error: running "go get golang.org/x/lint/golint" failed with exit code 2
🚨 Error: The command exited with status 2
user command error: exit status 2

because the underlying problem was already present, isn't related to this PR, and should be addressed in a follow up PR.

@dliappis dliappis merged commit 2a01286 into elastic:main Mar 18, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants