-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce checks for not supported annotations for Hints based autodiscover of Elastic Agent #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gizas
requested review from
faec,
leehinman,
MichaelKatsoulis,
tetianakravchenko and
constanca-m
March 6, 2024 12:10
7 tasks
constanca-m
reviewed
Mar 6, 2024
constanca-m
reviewed
Mar 6, 2024
constanca-m
reviewed
Mar 6, 2024
/test |
This was referenced Mar 7, 2024
gizas
added
the
Team:Cloudnative-Monitoring
Label for the Cloud Native Monitoring team
label
Mar 7, 2024
constanca-m
reviewed
Mar 8, 2024
@elastic/elastic-agent-data-plane could I have a review here please? |
constanca-m
approved these changes
Mar 12, 2024
faec
approved these changes
Mar 12, 2024
MichaelKatsoulis
approved these changes
Mar 13, 2024
💚 Build Succeeded
History
cc @gizas |
Merged
gizas
added a commit
that referenced
this pull request
Apr 15, 2024
Continuation of #81 We enhance the autodiscovery checks for supported hints to check multiple data_streams (in case of agent) and multiple metrcisets (in case of beats)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Team:Cloudnative-Monitoring
Label for the Cloud Native Monitoring team
Team:Elastic-Agent
Label for the Agent team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to elastic/elastic-agent#3064 and
elastic/elastic-agent#4360
It provides the checks for the supported hints.
This PR needs to be merged before the elastic/elastic-agent#4360