Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start supporting Python 3.11 #598

Closed

Conversation

bartbroere
Copy link
Contributor

The issue of PyTorch not supporting Python 3.11 (pytorch/pytorch#86566) seems to have been resolved. I did not see any apparent other issues with supporting Python 3.11 in the code.

@davidkyle davidkyle self-requested a review September 14, 2023 07:56
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change @bartbroere. Looks good but I'd like to test this on a couple of platforms first

requirements-dev.txt Show resolved Hide resolved
@davidkyle
Copy link
Member

Testing this I found it is not possible to install torch 1.13.1 with Python3.11.

Using pip install with Python 3.10 the install is successful:

/Library/Frameworks/Python.framework/Versions/3.10/bin/python3.10 -m pip install torch==1.13.1

With Python 3.11 the same install fails

/Library/Frameworks/Python.framework/Versions/3.11/bin/python3.11 -m pip install torch==1.13.1
ERROR: Could not find a version that satisfies the requirement torch==1.13.1 (from versions: 2.0.0, 2.0.1)
ERROR: No matching distribution found for torch==1.13.1

It looks like PyTorch 1.13.1 does not support Python 3.11, we will have to upgrade to PyTorch 2.0 for that support

@bartbroere did you get a different result?

@pquentin
Copy link
Member

pquentin commented Sep 21, 2023

PyTorch 1.13.1 only supports Python 3.11 on Linux, not on Windows or macOS, per the "cp311" files in https://pypi.org/project/torch/1.13.1/#files. It seems OK to support Python 3.11 on Linux but not on other platforms, but I'm biased as a Linux user :)

@davidkyle
Copy link
Member

Thanks @pquentin, allowing the option of using Python 3.11 generally will break model upload for too many users.

@bartbroere unless you have an objection I'd like to close this PR without merging as neither macOS or Windows users can use Python 3.11 with PyTorch 1.13.1

@bartbroere bartbroere closed this Sep 21, 2023
@bartbroere
Copy link
Contributor Author

Good discussion, and apologies I may not have had the right environment during testing this locally! I closed this pull request, since I agree it's wise not to merge this one until a newer Pytorch is supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants