-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start supporting Python 3.11 #598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change @bartbroere. Looks good but I'd like to test this on a couple of platforms first
Testing this I found it is not possible to install torch 1.13.1 with Python3.11. Using pip install with Python 3.10 the install is successful:
With Python 3.11 the same install fails
It looks like PyTorch 1.13.1 does not support Python 3.11, we will have to upgrade to PyTorch 2.0 for that support @bartbroere did you get a different result? |
PyTorch 1.13.1 only supports Python 3.11 on Linux, not on Windows or macOS, per the "cp311" files in https://pypi.org/project/torch/1.13.1/#files. It seems OK to support Python 3.11 on Linux but not on other platforms, but I'm biased as a Linux user :) |
Thanks @pquentin, allowing the option of using Python 3.11 generally will break model upload for too many users. @bartbroere unless you have an objection I'd like to close this PR without merging as neither macOS or Windows users can use Python 3.11 with PyTorch 1.13.1 |
Good discussion, and apologies I may not have had the right environment during testing this locally! I closed this pull request, since I agree it's wise not to merge this one until a newer Pytorch is supported. |
The issue of PyTorch not supporting Python 3.11 (pytorch/pytorch#86566) seems to have been resolved. I did not see any apparent other issues with supporting Python 3.11 in the code.