Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] data_stream fields #980
[RFC] data_stream fields #980
Changes from 7 commits
cdc9e49
11183d7
98f9d15
57ae392
8129746
763aa49
e8a96f4
f381b53
1b61d7f
42ea3ca
7bd6194
f939db3
ce737c2
9a179aa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this primer on the new indexing strategy, this is very helpful in explaining the context.
Additionally, if there is documentation on this indexing strategy or past discussions in public issues, we should link to it here and in the references at the bottom.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed today with @roncohen, if there's no public doc explaining the new indexing strategy yet, we can document it in detail in this RFC. This lets us capture all the thinking without worrying too much about where in the documentation will fit best.
I think it could ultimately make sense to have the public documentation for the strategy be published via the ECS docs. I'm mentioning this as a possibility, I'm fine also if this is captured elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ruflin has since started working on a doc which should explain this.