-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schemas/tracing.yml: add span.id #882
Conversation
Does it mean we have to change the query that correlates traces and logs so that we also query for |
@felixbarny not sure I follow, so I'll expand a bit on the problem. OpenTelemetry has no concept of transaction; a trace is just a collection of causally-ordered spans. Spans have a "kind", e.g. Server (i.e. server-side of a request) and Client (client-side of a request). We convert Server kind spans into transactions, but there's no reference to the that span's ID in other service-local spans, aside from its children. Even then we have no way of knowing the parent is the local root. So for OpenTelemetry, the best we can expect to have is:
We probably want to extend the Logs UI to query for |
So far, we only correlate based on the When jumping from the logs UI to the trace view, we currently also just consider the So I guess we don't need immediate changes. But we'll have to consider this for a potential logs tab in the transaction view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. Thanks everyone :-)
Add
span.id
to the tracing fields. This field may be useful for correlating logs with more specific operations, or wheretransaction.id
is unavailable.The
transaction.id
field is not always available for trace data received from other tracing systems, such as Jaeger and OpenTelemetry. We are guaranteed to havetrace.id
andspan.id
, but not necessarilytransaction.id
. Correlating logs with an entire trace (viatrace.id
) may result in too broad a set of results, compared to correlating withspan.id
.