Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding service.node.name #565

Merged
merged 6 commits into from
Sep 25, 2019
Merged

Adding service.node.name #565

merged 6 commits into from
Sep 25, 2019

Conversation

eyalkoren
Copy link
Contributor

Closes #538

@eyalkoren eyalkoren requested review from webmat and ruflin September 18, 2019 08:01
webmat
webmat suggested changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, thanks for sending this PR.

Just two things to adjust before we merge.

webmat
webmat reviewed Sep 23, 2019
View reviewed changes
webmat
webmat approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks for making the adjustments!

LGTM, once the changelog conflict is resolved :-)

@eyalkoren eyalkoren merged commit 6855c81 into elastic:master Sep 25, 2019
@eyalkoren eyalkoren deleted the adding-service-node-name branch September 25, 2019 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmat webmat webmat approved these changes

@ruflin ruflin ruflin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add service node name
3 participants
@eyalkoren @webmat @ruflin