-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add process.pgid field for processes group id #311
Conversation
Hey @jsoriano actually the best way here would be to make This way we'll be able to map very simply to WDYT? |
@webmat I am outside my knowledge base, but have to ask:
I am concerned from an ECS perspective that we'll now have double-nesting of re-usable fields, such as |
@jsoriano Actually you make a good point. I was conflating your need with another discussion we've been having over here: elastic/beats#10192. In this other situation, we are displaying all considered sources of information to determine the final / effective user and group ID. So the same event can potentially contain audit/effective/filesystem/saved/object IDs for user and group. In this case, it's necessary to nest everything in a structured manner. But you're right that if you have an event that describes one process, then |
Take into account that this
+1, I think we should keep this information at |
I have updated the description of the issue to remark that |
@webmat I have updated the branch, let me know if I should do something else to get this merged. |
Thanks @jsoriano. Regular work on improvements to ECS should slowly pick up again next week. Don't worry, I have this on my todo :-) |
@jsoriano Sorry for the time it took me to get back to working on ECS. @MikePaquette @ruflin This is ready to be merged, and I think it's fine as is. This adds another abbreviation field, which I think is fine, because it's consistent with Any objections to me merging this? |
Heads up, I'll be merging this tomorrow. |
pgid
is an identifier for groups of processes, it is usually thepid
ofthe leader of the group.