Adding the event.action field #26
Conversation
schemas/event.yml
Outdated
| description: > | ||
| The action taken by the event. | ||
|
|
||
| This is normally defined by the user. |
There was a problem hiding this comment.
Could you add a use case example here like one of the example discussed in #21.
|
@nick-george Yes, could you also add a changelog entry? |
|
Hi @ruflin, How do the new comments look? Cheers, |
|
LGTM. @andrewkroh @ave19 @praseodym Thoughts? |
|
LGTM too
On Wed, Jun 20, 2018, 6:30 AM Nicolas Ruflin ***@***.***> wrote:
LGTM. @andrewkroh <https://github.com/andrewkroh> @ave19
<https://github.com/ave19> @praseodym <https://github.com/praseodym>
Thoughts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AICmGneyhLSaqnESgmopx3LN-sU6_8_hks5t-kBZgaJpZM4UszH9>
.
--
…-ave
|
|
@nick-george I just added our standard CLA checker to the repo. Would you mind signing it? https://www.elastic.co/contributor-agreement |
Done. Thanks, |
|
@nick-george Seems like you signed the company CLA. Had to do some manual work to get it to green. But from now on the CLA check should always work. |
|
Merged. @nick-george Thanks for the contribution. |
|
Thanks for merging it! |
Hi @ruflin,
Is this what you had in mind for a PR in #21?
Cheers,
Nick