-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user.groups #204
Add user.groups #204
Conversation
I remember we had a discussion around this in the past. As in lucene single and multi values are the same, we should always stick to singular I think. For example |
@MikePaquette Does that make sense to you as well? |
Yes @webmat singular makes sense, even if it might contain multiple value. In ECS, we've been using plural only when the field "always" (or virtually aways) contains multiple. (e.g. *.bytes). |
Great! I'll rebase and merge, in this case. |
Also fix a field name mistake in the changelog for #204
Also fix a field name mistake in the changelog for elastic#204
Breaking change. Field set name "group" was being used as a leaf field at `user.group`. It had different semantics as the field set: it was a keyword field, instead of being a nesting of the field set. This goes against a driving principle of ECS, and has been corrected. We removed the `user.group` `keyword` field (introduced in #204), and made the `group` field set nestable at `user.group`.
Breaking change. Field set name "group" was being used as a leaf field at `user.group`. It had different semantics as the field set: it was a keyword field, instead of being a nesting of the field set. This goes against a driving principle of ECS, and has been corrected. We removed the `user.group` `keyword` field (introduced in elastic#204), and made the `group` field set nestable at `user.group`.
…#355) Cherry-pick of PR #308 to 1.0 branch. Original message: Breaking change. Field set name "group" was being used as a leaf field at `user.group`. It had different semantics as the field set: it was a keyword field, instead of being a nesting of the field set. This goes against a driving principle of ECS, and has been corrected. We removed the `user.group` `keyword` field (introduced in #204), and made the `group` field set nestable at `user.group`.
Question: singular or plural?