Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining golang dependencies #1585

Merged
merged 6 commits into from
Aug 23, 2021
Merged

Remove remaining golang dependencies #1585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
640cd58
install binary and remove dependency on Go for misspell install
ebeahan Aug 20, 2021
56d648c
remove license checker; only works with go source files
ebeahan Aug 20, 2021
b5252bc
fixes
ebeahan Aug 20, 2021
a9927b8
remove golang dep from workflow
ebeahan Aug 20, 2021
a026a53
Merge branch 'master' into remove-golang-dep-for-misspell
ebeahan Aug 20, 2021
a9592d3
changelog.next entry
ebeahan Aug 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ jobs:
name: Unit Tests
steps:
- uses: actions/checkout@v2
- uses: actions/setup-go@v2
with:
go-version: '1.15.x'
- uses: actions/setup-python@v2
with:
python-version: '3.x'
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.next.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ Thanks, you're awesome :-) -->

#### Improvements

* Remove remaining Go deps after removing Go code generator. #1585

#### Deprecated

## 1.12.0 (Feature Freeze)
Expand Down
17 changes: 8 additions & 9 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,12 @@ all: generate experimental
# Check verifies that all of the committed files that are generated are
# up-to-date.
.PHONY: check
check: generate experimental test fmt misspell makelint check-license-headers
check: generate experimental test fmt misspell makelint
# Check if diff is empty.
git diff | cat
git update-index --refresh
git diff-index --exit-code HEAD --

# Check license headers on files (currently .go files only).
.PHONY: check-license-headers
check-license-headers:
go get github.com/elastic/go-licenser
go-licenser -d

# Clean deletes all temporary and generated content.
.PHONY: clean
clean:
Expand Down Expand Up @@ -73,8 +67,13 @@ makelint:
# Check for basic misspellings.
.PHONY: misspell
misspell:
go get github.com/client9/misspell/cmd/misspell
misspell README.md CONTRIBUTING.md schemas/*
@if [ ! -d $(PWD)/build/misspell ]; then \
mkdir -p ./build/misspell/bin ; \
curl -sLo ./build/misspell/install-misspell.sh https://git.io/misspell ; \
chmod +x ./build/misspell/install-misspell.sh ; \
./build/misspell/install-misspell.sh -b ./build/misspell/bin >> /dev/null 2>&1 ; \
fi
./build/misspell/bin/misspell -error README.md CONTRIBUTING.md schemas/* docs/* experimental/schemas/*

.PHONY: reload_docs
reload_docs: generator docs
Expand Down