Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update user name & id docs for clarity #1566

Merged
merged 9 commits into from
Aug 16, 2021
Merged

Update user name & id docs for clarity #1566

merged 9 commits into from
Aug 16, 2021

Conversation

kgeller
Copy link
Contributor

@kgeller kgeller commented Aug 16, 2021

#1503

Adding/updating the user.id and user.name examples to try and provide clarity

@kgeller kgeller requested a review from ebeahan August 16, 2021 17:31
@kgeller kgeller marked this pull request as ready for review August 16, 2021 17:31
@kgeller kgeller changed the title Update user docs clarity Update user name & id docs for clarity Aug 16, 2021
ebeahan
ebeahan approved these changes Aug 16, 2021
View reviewed changes
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kgeller kgeller merged commit 68b334d into elastic:master Aug 16, 2021
@kgeller kgeller deleted the update-user-docs-clarity branch August 16, 2021 19:45
@kgeller kgeller mentioned this pull request Aug 16, 2021
Merged
kgeller added a commit that referenced this pull request Aug 16, 2021
@kgeller
Update user name & id docs for clarity (#1566) (#1568)
cc6e47e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebeahan ebeahan ebeahan approved these changes

Assignees
No one assigned
Labels
1.x 1.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kgeller @ebeahan