-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Present beta
tooltip for categorization values
#1511
Merged
ebeahan
merged 6 commits into
elastic:master
from
ebeahan:feature/beta-tooltip-on-categorization-values
Jul 13, 2021
Merged
Present beta
tooltip for categorization values
#1511
ebeahan
merged 6 commits into
elastic:master
from
ebeahan:feature/beta-tooltip-on-categorization-values
Jul 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgeller
approved these changes
Jul 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! LGTM
ebeahan
added a commit
to ebeahan/ecs
that referenced
this pull request
Jul 13, 2021
* include beta tooltip if beta attribute is present * test for presence of beta fields * changelog * add note about beta support in the README
ebeahan
added a commit
to ebeahan/ecs
that referenced
this pull request
Jul 13, 2021
* include beta tooltip if beta attribute is present * test for presence of beta fields * changelog * add note about beta support in the README
ebeahan
added a commit
that referenced
this pull request
Jul 13, 2021
ebeahan
added a commit
that referenced
this pull request
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow for a
beta
attribute to be defined on an ECS categorization allowed value and thatbeta
attribute's value to be passed into the ECS docs as abeta
tooltip.This expands the
beta
label supported initially added in #1051.Description
An allowed value defined underneath one of the ECS categorization fields will now support the
beta
attribute.It's defined on the desired value:
Will render as part of the allowed values description in the docs:
And will act as a tooltip displaying a
beta
notice when moused over: