Threat intelligence RFCs stage 2 addenda #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylnd
reviewed
Jul 7, 2021
There was a problem hiding this comment.
Gave this a once-over:
- Verified docs preview looks correct
- Verified that the JSON and YML files correctly declare enrichments as nested, and contain all relevant fields
The only thing potentially missing is an update to the original RFCs themselves? I know the changelog accounts for this, but I'm not sure if we should also include a mention of these changes in RFCs 8 and 21.
rylnd
approved these changes
Jul 7, 2021
peasead
approved these changes
Jul 8, 2021
ebeahan
added a commit
to ebeahan/ecs
that referenced
this pull request
Jul 8, 2021
* add addenda for RFC 0008 and 0021 * artifacts * changelog * correct reusable configuration for pe and registry * improve descriptions * reuse cleanup * artifacts * additional reuseable configuration cleanup # Conflicts: # experimental/generated/csv/fields.csv # generated/csv/fields.csv
ebeahan
added a commit
to ebeahan/ecs
that referenced
this pull request
Jul 8, 2021
* add addenda for RFC 0008 and 0021 * artifacts * changelog * correct reusable configuration for pe and registry * improve descriptions * reuse cleanup * artifacts * additional reuseable configuration cleanup # Conflicts: # experimental/generated/csv/fields.csv # generated/csv/fields.csv
ebeahan
added a commit
that referenced
this pull request
Jul 8, 2021
ebeahan
added a commit
that referenced
this pull request
Jul 8, 2021
This was referenced Aug 10, 2021
[Security Solution][CTI] Update legacy CTI signals to latest ECS threat fields
elastic/kibana#107988
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporate changes from the threat intelligence addenda for stage 2: #1502
Docs preview