Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stage 2 changes for RFC 0008 - threat indicator fields #1471

Merged
merged 8 commits into from
Jun 29, 2021
Merged

Stage 2 changes for RFC 0008 - threat indicator fields #1471

merged 8 commits into from
Jun 29, 2021

Conversation

ebeahan
Copy link
Member

@ebeahan ebeahan commented Jun 23, 2021 •
edited
Loading

Apply stage 2 beta changes proposed in the threat indicator fields RFC 0008: #1293

Docs preview of these changes

@ebeahan ebeahan self-assigned this Jun 23, 2021
@ebeahan ebeahan added the 1.11.0 label Jun 23, 2021
@ebeahan ebeahan marked this pull request as ready for review June 24, 2021 18:02
@ebeahan ebeahan requested review from rylnd, peasead and a team June 24, 2021 18:03
djptek
djptek reviewed Jun 28, 2021
View reviewed changes
Copy link
Contributor

@djptek djptek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm whether the underscores and extra "\n" characters are intentional? Otherwise looks OK though feedback from a domain SME would also be helpful

experimental/generated/beats/fields.ecs.yml Outdated Show resolved Hide resolved
experimental/generated/beats/fields.ecs.yml Show resolved Hide resolved
experimental/generated/ecs/ecs_flat.yml Outdated Show resolved Hide resolved
peasead
peasead approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@peasead peasead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djptek djptek self-requested a review June 29, 2021 13:20
djptek
djptek approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@djptek djptek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebeahan ebeahan merged commit 742b8f3 into elastic:master Jun 29, 2021
@ebeahan ebeahan deleted the rfc/0008/changes-for-stage-2 branch June 29, 2021 15:42
ebeahan added a commit to ebeahan/ecs that referenced this pull request Jun 29, 2021
@ebeahan
Stage 2 changes for RFC 0008 - threat indicator fields (elastic#1471)
c87f63a 
* remove experimental threat definitions

* add threat intel RFC beta fields

* add artifacts

* s/expected/recommended

* add changelog

* spaces anomaly

* artifacts
# Conflicts:
#	experimental/generated/csv/fields.csv
#	generated/csv/fields.csv
@ebeahan ebeahan mentioned this pull request Jun 29, 2021
Merged
ebeahan added a commit that referenced this pull request Jun 29, 2021
@ebeahan
Stage 2 changes for RFC 0008 - threat indicator fields (#1471) (#1485)
5c4b688 
* remove experimental threat definitions

* add threat intel RFC beta fields

* add artifacts

* s/expected/recommended

* add changelog

* spaces anomaly

* artifacts
@leehinman leehinman mentioned this pull request Jul 19, 2021
Closed
@ebeahan ebeahan mentioned this pull request Jul 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peasead peasead peasead approved these changes

@djptek djptek djptek approved these changes

@rylnd rylnd Awaiting requested review from rylnd

Assignees

@ebeahan ebeahan

Labels
1.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ebeahan @peasead @djptek