-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] match_only_text
type migration - Stage 1
#1415
Conversation
Notable changes for stage 1:
I'd appreciate it if reviewers would review and comment on:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest to add actionable item for performance impact analysis on both the two original fields as well as the 49 multi-fields added in Stage 1
sent a merge so the checks would pass |
After some out-of-band discussion on performance testing these changes, I'm removing the Migrating the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Holding off on merging until potential performance impact is assessed. |
Summary
Continuing onto Stage 1 proposal for migrating
text
type fields, including themessage
base field, to use thematch_only_text
data type being introduced in Elasticsearch 7.14.Stage 1 (Draft) Criteria:
Preview of markdown proposal