Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strawperson (stage 0) Kubernetes RFC #1209

Merged
merged 7 commits into from
Jan 11, 2021
Merged

Add strawperson (stage 0) Kubernetes RFC #1209

merged 7 commits into from
Jan 11, 2021

Conversation

ferozsalam
Copy link
Contributor

I have written a strawperson RFC stub to begin the process of moving the existing Kubernetes use-case into a full ECS schema of its own. More details are in the commit diff, please let me know if there's anything more I can clarify.


  • Have you signed the contributor license agreement? Yes
  • Have you followed the contributor guidelines? Yes
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process? Yes
  • If submitting code/script changes, have you verified all tests pass locally using make test? N/A
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes? N/A
  • Is your pull request against master? Yes
  • Have you added an entry to the CHANGELOG.next.md? N/A

@ebeahan ebeahan added the RFC label Jan 4, 2021
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this and submitting it, @ferozsalam!

Adding fields to better support container orchestration solutions has been discussed, but this proposal is a great step towards formalizing the conversation.

@ferozsalam
Copy link
Contributor Author

ferozsalam commented Jan 8, 2021

@ebeahan Thanks for your review! I have addressed all your comments, let me know if this looks OK now.

Edit: made some more tweaks so that the RFC summary is more generic and less k8s-specific.

ebeahan
ebeahan previously approved these changes Jan 11, 2021
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! LGTM 👍

I'll assign the RFC a number, set the date in the proposal, and merge.

@ebeahan ebeahan merged commit 8134642 into elastic:master Jan 11, 2021
@ebeahan
Copy link
Member

ebeahan commented Jan 19, 2021

Once again, thanks, @ferozsalam, for submitting this PR.

We'll work on identifying a sponsor for this RFC within Elastic.

If you're willing to keep working on this, you're welcome to open the stage one pull request. If not, your feedback is welcomed on any following stage PRs! 😃

In stage one, we'll want to address the following:

  • Propose an initial set of field definitions for orchestrator.*.
  • Describe further at a high-level how these fields will be used in practice
  • Include real-world example documents.
  • Identify any potential concerns, implementation challenges, or complexity.
  • Officially identify the sponsor (that one's on Elastic's end 😄 )

@ferozsalam
Copy link
Contributor Author

Hey @ebeahan I definitely intend to see this through, but it's been a busy week! I expect to have a draft ready before 7pm UTC tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants