Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of brackets for a URL containing IPv6 address #1131

Merged
merged 5 commits into from
Dec 3, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.next.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ Thanks, you're awesome :-) -->

#### Improvements

* Note `[` and `]` bracket characters may enclose a literal IPv6 address when populating `url.domain`. #1131

#### Deprecated

### Tooling and Artifact Changes
Expand Down
3 changes: 3 additions & 0 deletions code/go/ecs/url.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions docs/field-details.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -6236,6 +6236,8 @@ URL fields provide support for complete or partial URLs, and supports the breaki

In some cases a URL may refer to an IP and/or port directly, without a domain name. In this case, the IP address would go to the `domain` field.

If the URL contains a literal IPv6 address enclosed by `[` and `]` (IETF RFC 2732), the `[` and `]` characters should also be captured in the `domain` field.

type: keyword


Expand Down
6 changes: 5 additions & 1 deletion experimental/generated/beats/fields.ecs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5262,7 +5262,11 @@
description: 'Domain of the url, such as "www.elastic.co".

In some cases a URL may refer to an IP and/or port directly, without a domain
name. In this case, the IP address would go to the `domain` field.'
name. In this case, the IP address would go to the `domain` field.

If the URL contains a literal IPv6 address enclosed by `[` and `]` (IETF RFC
2732), the `[` and `]` characters should also be captured in the `domain`
field.'
example: www.elastic.co
- name: extension
level: extended
Expand Down
5 changes: 4 additions & 1 deletion experimental/generated/ecs/ecs_flat.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8027,7 +8027,10 @@ url.domain:
description: 'Domain of the url, such as "www.elastic.co".

In some cases a URL may refer to an IP and/or port directly, without a domain
name. In this case, the IP address would go to the `domain` field.'
name. In this case, the IP address would go to the `domain` field.

If the URL contains a literal IPv6 address enclosed by `[` and `]` (IETF RFC 2732),
the `[` and `]` characters should also be captured in the `domain` field.'
example: www.elastic.co
flat_name: url.domain
level: extended
Expand Down
6 changes: 5 additions & 1 deletion experimental/generated/ecs/ecs_nested.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9291,7 +9291,11 @@ url:
description: 'Domain of the url, such as "www.elastic.co".

In some cases a URL may refer to an IP and/or port directly, without a domain
name. In this case, the IP address would go to the `domain` field.'
name. In this case, the IP address would go to the `domain` field.

If the URL contains a literal IPv6 address enclosed by `[` and `]` (IETF RFC
2732), the `[` and `]` characters should also be captured in the `domain`
field.'
example: www.elastic.co
flat_name: url.domain
level: extended
Expand Down
6 changes: 5 additions & 1 deletion generated/beats/fields.ecs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5350,7 +5350,11 @@
description: 'Domain of the url, such as "www.elastic.co".

In some cases a URL may refer to an IP and/or port directly, without a domain
name. In this case, the IP address would go to the `domain` field.'
name. In this case, the IP address would go to the `domain` field.

If the URL contains a literal IPv6 address enclosed by `[` and `]` (IETF RFC
2732), the `[` and `]` characters should also be captured in the `domain`
field.'
example: www.elastic.co
- name: extension
level: extended
Expand Down
5 changes: 4 additions & 1 deletion generated/ecs/ecs_flat.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8110,7 +8110,10 @@ url.domain:
description: 'Domain of the url, such as "www.elastic.co".

In some cases a URL may refer to an IP and/or port directly, without a domain
name. In this case, the IP address would go to the `domain` field.'
name. In this case, the IP address would go to the `domain` field.

If the URL contains a literal IPv6 address enclosed by `[` and `]` (IETF RFC 2732),
the `[` and `]` characters should also be captured in the `domain` field.'
example: www.elastic.co
flat_name: url.domain
ignore_above: 1024
Expand Down
6 changes: 5 additions & 1 deletion generated/ecs/ecs_nested.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9379,7 +9379,11 @@ url:
description: 'Domain of the url, such as "www.elastic.co".

In some cases a URL may refer to an IP and/or port directly, without a domain
name. In this case, the IP address would go to the `domain` field.'
name. In this case, the IP address would go to the `domain` field.

If the URL contains a literal IPv6 address enclosed by `[` and `]` (IETF RFC
2732), the `[` and `]` characters should also be captured in the `domain`
field.'
example: www.elastic.co
flat_name: url.domain
ignore_above: 1024
Expand Down
3 changes: 3 additions & 0 deletions schemas/url.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@

In some cases a URL may refer to an IP and/or port directly, without a
domain name. In this case, the IP address would go to the `domain` field.

If the URL contains a literal IPv6 address enclosed by `[` and `]` (IETF RFC 2732),
the `[` and `]` characters should also be captured in the `domain` field.
example: www.elastic.co

- name: registered_domain
Expand Down