Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.5] Add [discrete] headers to Asciidoc generator #1089

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

ebeahan
Copy link
Member

@ebeahan ebeahan commented Nov 4, 2020

I made these changes locally but failed to include them in #1003.

These changes ensure any subsequent changes to the documentations will also include the [discrete] markers in the field details documentation section.

@ebeahan ebeahan self-assigned this Nov 4, 2020
@ebeahan
Copy link
Member Author

ebeahan commented Nov 4, 2020

Resolves the issue raised at #1082 (comment)

@ebeahan ebeahan requested a review from webmat November 4, 2020 20:19
@ebeahan ebeahan changed the title Add [discrete] headers to Asciidoc generator [1.5] Add [discrete] headers to Asciidoc generator Nov 4, 2020
Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the fix :-)

Could you try to backport it to 1.4 and 1.3? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants