Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.6][DOCS] Adding discrete markers #1002

Merged
merged 2 commits into from
Oct 5, 2020
Merged

[1.6][DOCS] Adding discrete markers #1002

merged 2 commits into from
Oct 5, 2020

Conversation

ebeahan
Copy link
Member

@ebeahan ebeahan commented Oct 5, 2020

Backports doc changes from #989

@ebeahan ebeahan self-assigned this Oct 5, 2020
@ebeahan
Copy link
Member Author

ebeahan commented Oct 5, 2020 •
edited
Loading

Travis build failure is expected

Back to ✅

webmat
webmat suggested changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@webmat webmat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For 1.6 branch we should adjust the script. The actual 1.7 release is over a month away, so we may occasionally backport small fixes to 1.6 until then.

So having the scripts do the right thing is a must for this branch.

@ebeahan ebeahan requested a review from webmat October 5, 2020 19:08
webmat
webmat approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ebeahan ebeahan merged commit 5d92d40 into elastic:1.6 Oct 5, 2020
@ebeahan ebeahan deleted the backports/1.6/add-discrete-headers branch October 5, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmat webmat webmat approved these changes

Assignees

@ebeahan ebeahan

Labels
backport documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ebeahan @webmat