Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field: process.thread.name #507

Closed
felixbarny opened this issue Jul 29, 2019 · 6 comments · Fixed by #517
Closed

Add field: process.thread.name #507

felixbarny opened this issue Jul 29, 2019 · 6 comments · Fixed by #517

Comments

@felixbarny
Copy link
Member

There is already process.thread.id, however, a thread name is arguably more descriptive. The use case for this would be Java logging, for example. For this use case, it's useful to see in which thread a log has been emitted.

@cpmoore
Copy link
Contributor

cpmoore commented Aug 5, 2019

In our own implementation we're already using process.thread.name. Some of our java applications log only log the thread name, eg Default Executor-thread-6308

@felixbarny
Copy link
Member Author

@cpmoore I'm interested in your setup: are you logging as JSON or parsing plain-text log files with logstash/filebeat/ingest node?

@cpmoore
Copy link
Contributor

cpmoore commented Aug 6, 2019

@felixbarny We’re using filebeat to send plain text logs to logstash and parsing them with a grok filter.
This specific application I was referring to above is a vendor provided application to which we have no way of configuring It’s logging format.

@webmat
Copy link
Contributor

webmat commented Aug 12, 2019

Yes, adding this field makes sense and is straightforward.

I'm adding it to my (long) list of quick fixes. Of course if someone has the time to send over a PR for this, I can fast track the approval :-)

@cpmoore
Copy link
Contributor

cpmoore commented Aug 12, 2019

@webmat

I believe I opened the PR correctly. Still kinda a newbie 😄

@webmat
Copy link
Contributor

webmat commented Aug 13, 2019

@cpmoore You did, and were successful on the first try (no missing make & such).

Thank you! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants