Skip to content

Commit

Permalink
Remove misleading wording about multiple IPs in src/dst or cli/srv (#804
Browse files Browse the repository at this point in the history 
)
  • Loading branch information
Mathieu Martin authored Mar 26, 2020
1 parent 4587399 commit 816ed67
Show file tree
Hide file tree
Showing 13 changed files with 25 additions and 68 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.next.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ Thanks, you're awesome :-) -->

* Remove misleading pluralization in the description of `user.id`, it should
contain one ID, not many. #801
* Clarified misleading wording about multiple IPs in src/dst or cli/srv. #804

#### Deprecated

Expand Down
3 changes: 1 addition & 2 deletions code/go/ecs/client.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions code/go/ecs/destination.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions code/go/ecs/server.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions code/go/ecs/source.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 4 additions & 12 deletions docs/field-details.asciidoc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -290,9 +290,7 @@ type: keyword
// ===============================================================

| client.ip
| IP address of the client.

Can be one or multiple IPv4 or IPv6 addresses.
| IP address of the client (IPv4 or IPv6).

type: ip

Expand Down Expand Up @@ -800,9 +798,7 @@ type: keyword
// ===============================================================

| destination.ip
| IP address of the destination.

Can be one or multiple IPv4 or IPv6 addresses.
| IP address of the destination (IPv4 or IPv6).

type: ip

Expand Down Expand Up @@ -5105,9 +5101,7 @@ type: keyword
// ===============================================================

| server.ip
| IP address of the server.

Can be one or multiple IPv4 or IPv6 addresses.
| IP address of the server (IPv4 or IPv6).

type: ip

Expand Down Expand Up @@ -5442,9 +5436,7 @@ type: keyword
// ===============================================================

| source.ip
| IP address of the source.

Can be one or multiple IPv4 or IPv6 addresses.
| IP address of the source (IPv4 or IPv6).

type: ip

Expand Down
16 changes: 4 additions & 12 deletions generated/beats/fields.ecs.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -248,9 +248,7 @@
- name: ip
level: core
type: ip
description: 'IP address of the client.
Can be one or multiple IPv4 or IPv6 addresses.'
description: IP address of the client (IPv4 or IPv6).
- name: mac
level: core
type: keyword
Expand Down Expand Up @@ -617,9 +615,7 @@
- name: ip
level: core
type: ip
description: 'IP address of the destination.
Can be one or multiple IPv4 or IPv6 addresses.'
description: IP address of the destination (IPv4 or IPv6).
- name: mac
level: core
type: keyword
Expand Down Expand Up @@ -3737,9 +3733,7 @@
- name: ip
level: core
type: ip
description: 'IP address of the server.
Can be one or multiple IPv4 or IPv6 addresses.'
description: IP address of the server (IPv4 or IPv6).
- name: mac
level: core
type: keyword
Expand Down Expand Up @@ -4048,9 +4042,7 @@
- name: ip
level: core
type: ip
description: 'IP address of the source.
Can be one or multiple IPv4 or IPv6 addresses.'
description: IP address of the source (IPv4 or IPv6).
- name: mac
level: core
type: keyword
Expand Down
16 changes: 4 additions & 12 deletions generated/ecs/ecs_flat.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -306,9 +306,7 @@ client.geo.region_name:
type: keyword
client.ip:
dashed_name: client-ip
description: 'IP address of the client.
Can be one or multiple IPv4 or IPv6 addresses.'
description: IP address of the client (IPv4 or IPv6).
flat_name: client.ip
level: core
name: ip
Expand Down Expand Up @@ -950,9 +948,7 @@ destination.geo.region_name:
type: keyword
destination.ip:
dashed_name: destination-ip
description: 'IP address of the destination.
Can be one or multiple IPv4 or IPv6 addresses.'
description: IP address of the destination (IPv4 or IPv6).
flat_name: destination.ip
level: core
name: ip
Expand Down Expand Up @@ -6443,9 +6439,7 @@ server.geo.region_name:
type: keyword
server.ip:
dashed_name: server-ip
description: 'IP address of the server.
Can be one or multiple IPv4 or IPv6 addresses.'
description: IP address of the server (IPv4 or IPv6).
flat_name: server.ip
level: core
name: ip
Expand Down Expand Up @@ -6978,9 +6972,7 @@ source.geo.region_name:
type: keyword
source.ip:
dashed_name: source-ip
description: 'IP address of the source.
Can be one or multiple IPv4 or IPv6 addresses.'
description: IP address of the source (IPv4 or IPv6).
flat_name: source.ip
level: core
name: ip
Expand Down
16 changes: 4 additions & 12 deletions generated/ecs/ecs_nested.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -418,9 +418,7 @@ client:
type: keyword
ip:
dashed_name: client-ip
description: 'IP address of the client.
Can be one or multiple IPv4 or IPv6 addresses.'
description: IP address of the client (IPv4 or IPv6).
flat_name: client.ip
level: core
name: ip
Expand Down Expand Up @@ -1115,9 +1113,7 @@ destination:
type: keyword
ip:
dashed_name: destination-ip
description: 'IP address of the destination.
Can be one or multiple IPv4 or IPv6 addresses.'
description: IP address of the destination (IPv4 or IPv6).
flat_name: destination.ip
level: core
name: ip
Expand Down Expand Up @@ -6989,9 +6985,7 @@ server:
type: keyword
ip:
dashed_name: server-ip
description: 'IP address of the server.
Can be one or multiple IPv4 or IPv6 addresses.'
description: IP address of the server (IPv4 or IPv6).
flat_name: server.ip
level: core
name: ip
Expand Down Expand Up @@ -7552,9 +7546,7 @@ source:
type: keyword
ip:
dashed_name: source-ip
description: 'IP address of the source.
Can be one or multiple IPv4 or IPv6 addresses.'
description: IP address of the source (IPv4 or IPv6).
flat_name: source.ip
level: core
name: ip
Expand Down
4 changes: 1 addition & 3 deletions schemas/client.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,7 @@
type: ip
short: IP address of the client.
description: >
IP address of the client.
Can be one or multiple IPv4 or IPv6 addresses.
IP address of the client (IPv4 or IPv6).
- name: port
format: string
Expand Down
4 changes: 1 addition & 3 deletions schemas/destination.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,7 @@
type: ip
short: IP address of the destination.
description: >
IP address of the destination.
Can be one or multiple IPv4 or IPv6 addresses.
IP address of the destination (IPv4 or IPv6).
- name: port
format: string
Expand Down
4 changes: 1 addition & 3 deletions schemas/server.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,7 @@
type: ip
short: IP address of the server.
description: >
IP address of the server.
Can be one or multiple IPv4 or IPv6 addresses.
IP address of the server (IPv4 or IPv6).
- name: port
format: string
Expand Down
4 changes: 1 addition & 3 deletions schemas/source.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,7 @@
type: ip
short: IP address of the source.
description: >
IP address of the source.
Can be one or multiple IPv4 or IPv6 addresses.
IP address of the source (IPv4 or IPv6).
- name: port
format: string
Expand Down

0 comments on commit 816ed67

Please sign in to comment.