This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 41
Fleet goal #784
Merged
v1v
merged 1 commit into
elastic:master
from
v1v:feature/support-elastic-agent-entrypoint
Feb 22, 2021
Merged
Fleet goal #784
v1v
merged 1 commit into
elastic:master
from
v1v:feature/support-elastic-agent-entrypoint
Feb 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errors
Expand to view the tests failures
|
mdelapenya
reviewed
Feb 19, 2021
STACK_VERSION=${1:-'8.0.0-SNAPSHOT'} | ||
SUITE='fleet' | ||
|
||
.ci/scripts/functional-test.sh "${SUITE}" "" "${STACK_VERSION}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a follow-up I'm thinking about merging the METRICBEAT_VERSION and ELASTIC_AGENT_VERSION into BEAT_VERSION, (same for the stack version var), so at some point we will be able to add the forth parameter with the beat version.
mdelapenya
approved these changes
Feb 19, 2021
v1v
added a commit
to v1v/e2e-testing
that referenced
this pull request
Feb 22, 2021
v1v
added a commit
to v1v/e2e-testing
that referenced
this pull request
Feb 22, 2021
v1v
added a commit
to v1v/e2e-testing
that referenced
this pull request
Feb 22, 2021
v1v
added a commit
to v1v/e2e-testing
that referenced
this pull request
Feb 22, 2021
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable metricbeat script to delegate all the logic to this repo then the consumer only need to call the script
Why is it important?
Simplify the consumer calls
Checklist
[ ] My code follows the style guidelines of this project[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have run the Unit tests for the CLI, and they are passing locally[ ] I have noticed new Go dependencies (runmake notice
in the proper directory)Author's Checklist
How to test this PR locally
Run the script
.ci/scripts/fleet-test.sh
Related issues
Similar too #705 and required by elastic/beats#24112