This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
chore: refactor build artifacts methods (#689) backport for 6.8.x #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: use local beats directory for elastic-agent installers * docs: document BEATS_LOCAL_PATH variable * chore: check that the local file exists * chore: add unit tests for the BEATS_LOCAL_PATH variable * chore: simplify logic after test coverage * chore: enrich test name * chore: rename test * chore: move default values to the end of the descriptions * chore: add a helper method to build artifact names * chore: build artifact name only once * chore: pass the entire filename to calculate the GCP bucket coordinates * chore: simplify method signature, as the file name is not changed within the method * chore: use buildArtifactName method * chore: pass filename to helper methods to avoid unnecessary calculations * chore: rename variable for consistency * chore: add license headers * chore: use lowercase comparison for artifact name * chore: build artifact changes from Beats CI to Elastic's artifactory * fix: support building artifact names from local Local builds uses the same as the CI * WIP * fix: rename docker-ubi8 installer key * chore: pass a fallback version when building artifact name In the case we are using a PR , where the version is "pr-12345", then we need to use the base version of the product * chore: remove log * fix: do not override artifact name in Docker installer * feat: support consuming the docker images from snapshots or local in standalone mode * chore: add unit tests for fetching docker images from local Beats repo * chore: apply version to Docker installer * chore: support loading metricbeat image from local repository * chore: exrtact loadImage method to docker helper * feat: support consuming CI artifacts in metricbeat * fix: remove non-existent field from logrus log * chore: extract download logic to helper methods We are discarding the stale parameter, because the stale version is set when the installer is required, so we simply download what is requested * chore: fix typo * chore: check agent version before setting it * chore: use the docker client to load the image instead of the docker binary * chore: add unit tests for check method * chore: pass fallback version to check method * fix: properly calculate version for PRs * chore: move PR check logic to a method * chore: make test independent of maintenance branch # Conflicts: # e2e/_suites/fleet/fleet.go # e2e/_suites/fleet/ingest-manager_test.go # e2e/_suites/fleet/installers.go # e2e/_suites/fleet/services.go # e2e/_suites/fleet/services_test.go
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Steps errors
Expand to view the steps failures
|
| Test | Results |
|---|---|
| Failed | 0 |
| Passed | 38 |
| Skipped | 9 |
| Total | 47 |
|
One backport is missing in this branch. Closing and investigating |
|
Superseded by #713 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 6.8.x: