This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
feat: support executing nightly tests on CI #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errors
Expand to view the tests failures
|
kuisathaverat
approved these changes
Jan 27, 2021
mdelapenya
commented
Jan 27, 2021
.ci/Jenkinsfile
Outdated
Comment on lines
323
to
325
| tags += " && ${NIGHTLY_TAG}" | ||
| } else { | ||
| tags += " && ~${NIGHTLY_TAG}" |
There was a problem hiding this comment.
This is incorrect as it is saying:
Use the existing tags and exclude the nightly tag if it is disabled
and
Use the existing tags and add the nightly tag if it is enabled
The second is wrong as it will get all scenarios containing the tags AND nightly, which means it will only run the nightly scenario. It should be a (($tags) OR nightly)
I'm designing it in another manner
mdelapenya
force-pushed
the
652-nightly-tags
branch
from
8e1be8c to
b81ab1c
Compare
|
jenkins run the tests please |
10 tasks
|
jenkins run the tests please |
cachedout
approved these changes
Feb 1, 2021
|
jenkins run the tests please |
|
Same 3 errors as in master. Merging |
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Feb 1, 2021
* docs: document SKIP_SCENARIOS variable * chore: support running nightly scenarios only from the nighltly builds * fix: wrong variable assignment
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Feb 1, 2021
* docs: document SKIP_SCENARIOS variable * chore: support running nightly scenarios only from the nighltly builds * fix: wrong variable assignment
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Feb 1, 2021
* docs: document SKIP_SCENARIOS variable * chore: support running nightly scenarios only from the nighltly builds * fix: wrong variable assignment
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Feb 1, 2021
* docs: document SKIP_SCENARIOS variable * chore: support running nightly scenarios only from the nighltly builds * fix: wrong variable assignment
mdelapenya
added a commit
that referenced
this pull request
Feb 1, 2021
mdelapenya
added a commit
that referenced
this pull request
Feb 1, 2021
mdelapenya
added a commit
that referenced
this pull request
Feb 1, 2021
mdelapenya
added a commit
that referenced
this pull request
Feb 1, 2021
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It instruments the CI to be able to modify the tags to be run in the CI test execution, adding or excluding the
@nightlytag from Godog. To achieve that, we have defined a global environment variable for the tag to be added/excluded, NIGHTLY_TAG, and a Jenkins input parameter to control the nightly tags, NIGHTLY_SCENARIOS, which takesfalseas default value.Finally, the nightly job for Fleet will trigger the main job setting the new parameter with
truevalue, although it's also possible to run thee nightly tests when running the main job manually, be it a PR or a branch.Why is it important?
We want Fleet's nightly build to run the tests that are marked as
@nightly.Checklist
make noticein the proper directory)Related issues
Use cases
Follow-ups
We still have to replace the
@skiptag from the Upgrade tests with@nightly, but we are going to do that in another R, as we are testing its behaviour before enabling it back.