This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
chore: use a more structured YAML format #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuisathaverat
approved these changes
Jan 25, 2021
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
| Test | Results |
|---|---|
| Failed | 0 |
| Passed | 52 |
| Skipped | 11 |
| Total | 63 |
cachedout
approved these changes
Jan 26, 2021
mdelapenya
changed the title
mdelapenya
commented
Jan 26, 2021
.ci/Jenkinsfile
Outdated
| log(level: 'WARN', text: "The ${suite}:${tags} test suite won't be executed because there are no modified files") | ||
| def checkTestSuite(Map parallelTasks = [:], Map item = [:]) { | ||
| def suite = item.suite | ||
| def platforms = suite.platforms |
There was a problem hiding this comment.
CI is failing with:
No such field found: field java.lang.String platforms
Any guess?
There was a problem hiding this comment.
is it a list? or maybe item.platforms similar to item.scenarios
There was a problem hiding this comment.
There was a problem hiding this comment.
My bad... I've just seen it... It's item.platforms instead of suite.platforms
|
I'm going to merge this. It seems a good starting point to add more functionality on top of it. The simplest one related to supporting more platforms (arm?): it would be just a matter of adding a new entry in the platforms element in the platforms:
- "ubuntu-18.04"
- "new-supported-platform" |
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 26, 2021
* chore: use a more structurated YAML format * feat: support setting target platform for the CI nodes * fix: wrong item reference * chore: move variable outside the loop * fix: remove variable * fix: use the proper entity to read the platforms
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errors
Expand to view the tests failures
|
| Test | Results |
|---|---|
| Failed | 5 |
| Passed | 106 |
| Skipped | 11 |
| Total | 122 |
Genuine test errors 
💔 There are test failures but not known flaky tests, most likely a genuine test failure.
- Name:
Initializing / End-To-End Tests / ubuntu-18.04_fleet_agent_endpoint_integration / Adding the Endpoint Integration to an Agent makes the host to show in Security App – Agent Endpoint Integration - Name:
Initializing / End-To-End Tests / ubuntu-18.04_fleet_agent_endpoint_integration / Deploying an Endpoint makes policies to appear in the Security App – Agent Endpoint Integration - Name:
Initializing / End-To-End Tests / ubuntu-18.04_fleet_agent_endpoint_integration / Changing an Agent policy is reflected in the Security App – Agent Endpoint Integration - Name:
Initializing / End-To-End Tests / ubuntu-18.04_fleet_fleet_mode_agent / Re-enrolling the centos agent – Fleet Mode Agent - Name:
Initializing / End-To-End Tests / ubuntu-18.04_fleet_fleet_mode_agent / Re-enrolling the debian agent – Fleet Mode Agent
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 26, 2021
* chore: use a more structurated YAML format * feat: support setting target platform for the CI nodes * fix: wrong item reference * chore: move variable outside the loop * fix: remove variable * fix: use the proper entity to read the platforms
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 26, 2021
* chore: use a more structurated YAML format * feat: support setting target platform for the CI nodes * fix: wrong item reference * chore: move variable outside the loop * fix: remove variable * fix: use the proper entity to read the platforms
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 26, 2021
* chore: use a more structurated YAML format * feat: support setting target platform for the CI nodes * fix: wrong item reference * chore: move variable outside the loop * fix: remove variable * fix: use the proper entity to read the platforms
mdelapenya
added a commit
that referenced
this pull request
Jan 26, 2021
* chore: use a more structurated YAML format * feat: support setting target platform for the CI nodes * fix: wrong item reference * chore: move variable outside the loop * fix: remove variable * fix: use the proper entity to read the platforms
mdelapenya
added a commit
that referenced
this pull request
Jan 26, 2021
* chore: use a more structurated YAML format * feat: support setting target platform for the CI nodes * fix: wrong item reference * chore: move variable outside the loop * fix: remove variable * fix: use the proper entity to read the platforms
mdelapenya
added a commit
that referenced
this pull request
Jan 26, 2021
* chore: use a more structurated YAML format * feat: support setting target platform for the CI nodes * fix: wrong item reference * chore: move variable outside the loop * fix: remove variable * fix: use the proper entity to read the platforms
mdelapenya
added a commit
that referenced
this pull request
Jan 26, 2021
* chore: use a more structurated YAML format * feat: support setting target platform for the CI nodes * fix: wrong item reference * chore: move variable outside the loop * fix: remove variable * fix: use the proper entity to read the platforms
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It refactors the existing YAML file that configures the parallel branches in the CI pipeline. Instead of having an array of simple items, we are adding a more complex structure, trying to enrich the model for future enhacements.
Why is it important?
We'd like to support more complex CI configurations, like multiple platforms, or different conditions to run test stages, and previous configuration was not supporting it.
The original use case is to run nightly builds with different tags than in the PR build.
Checklist
make noticein the proper directory)Related issues
Follow-ups
We want to iterate through this PR to enhance the CI flow for this PR, maybe using the
beatsWhento identify events triggering the build.