This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
feat: support a comma-separated list of test suites #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelapenya
commented
Sep 23, 2020
.ci/Jenkinsfile
Outdated
| @@ -237,20 +244,30 @@ pipeline { | |||
| success { | |||
| whenTrue(!isPR() && params.notifyOnGreenBuilds) { | |||
| slackSend(channel: "#${env.SLACK_CHANNEL}", color: 'good', | |||
| message: "[${params.runTestsSuite}] Build Passed: ${env.JOB_NAME} ${env.BUILD_NUMBER} (<${env.RUN_DISPLAY_URL}|Open>).", | |||
| message: "[${params.runTestsSuites}] Build Passed: ${env.JOB_NAME} ${env.BUILD_NUMBER} (<${env.RUN_DISPLAY_URL}|Open>).", | |||
There was a problem hiding this comment.
Mmmm, this should have better format when multiple suites have been passed
There was a problem hiding this comment.
Another mmm... what if the value is empty (meaning all)?
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
v1v
reviewed
Sep 24, 2020
mdelapenya
commented
Sep 24, 2020
mdelapenya
commented
Sep 24, 2020
v1v
approved these changes
Sep 28, 2020
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Sep 28, 2020
* chore: rename variable to represent godog tags * fix: double quote variable * chore: rename jenkins parameter * chore: use empty instead of all as value for the tags to be run * chore: simplify variable value * chore: rename variable * feat: support passing a comma-separated list of test suites to be run * chore: extract common code to a method * chore: rename variable * chore: trim test suite in the list * chore: add logs * fix: forgot "each" for the array * chore: extract slack send to a function * chore: format slack message * chore: format message for empty test suites * chore: rename variable to avoid conflicts with Jenkins params * chore: simplify loop Co-authored-by: Victor Martinez <[email protected]> * chore: simplify variables inside loop Co-authored-by: Victor Martinez <[email protected]> # Conflicts: # .ci/scripts/functional-test.sh
mdelapenya
added a commit
that referenced
this pull request
Sep 28, 2020
* chore: rename variable to represent godog tags * fix: double quote variable * chore: rename jenkins parameter * chore: use empty instead of all as value for the tags to be run * chore: simplify variable value * chore: rename variable * feat: support passing a comma-separated list of test suites to be run * chore: extract common code to a method * chore: rename variable * chore: trim test suite in the list * chore: add logs * fix: forgot "each" for the array * chore: extract slack send to a function * chore: format slack message * chore: format message for empty test suites * chore: rename variable to avoid conflicts with Jenkins params * chore: simplify loop Co-authored-by: Victor Martinez <[email protected]> * chore: simplify variables inside loop Co-authored-by: Victor Martinez <[email protected]> # Conflicts: # .ci/scripts/functional-test.sh
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It refactors the jenkinsfile logic to support this. To achieve it, we:
Why is it important?
It will allow to execute more than one test suite from an upstream job (and also from here!)
Checklist
make noticein the proper directory)How to test this locally
if we want to test that the refactor of the variables s OK, rom the root directory of the project:
$ SUITE=ingest-manager TAGS="fleet_mode && enroll" LOG_LEVEL=TRACE make -C e2e functional-testDesired executed command:
godog --tags "fleet_mode && enroll"About the comma-separated list of strings, it happens on Jenkins time, so not possible to test it locally.
Related issues
Screenshots
Running with
runTestsSuites="helm, metricbeat"Follow-ups
Update elastic/beats#21100 with the updated parameter.