Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

chore: increase build timeout to 90 minutes #2139

Merged
merged 2 commits into from
Feb 10, 2022

Conversation

mdelapenya
Copy link
Contributor

@mdelapenya mdelapenya commented Feb 10, 2022

What does this PR do?

It updates the build timeout from 60 mins to 90.

Why is it important?

With the move to VMs, we are very close now to the 60 mins max build time. Increasing it to 90, although not desired as a long term solution, could help as to not let certain builds fail.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the Unit tests (make unit-test), and they are passing locally
  • I have run the End-2-End tests for the suite I'm working on, and they are passing locally
  • I have noticed new Go dependencies (run make notice in the proper directory)

@mdelapenya mdelapenya added the backport-skip Skip notification from the automated backport with mergify label Feb 10, 2022
@mdelapenya mdelapenya self-assigned this Feb 10, 2022
@mdelapenya mdelapenya requested a review from a team February 10, 2022 16:06
@mergify
Copy link
Contributor

mergify bot commented Feb 10, 2022

This pull request is now in conflict. Could you fix it @mdelapenya? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b increase-build-time upstream/increase-build-time
git merge upstream/main
git push upstream increase-build-time

@mdelapenya mdelapenya merged commit 5179a43 into elastic:main Feb 10, 2022
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Feb 28, 2022
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Feb 28, 2022
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Feb 28, 2022
mdelapenya added a commit that referenced this pull request Feb 28, 2022
mdelapenya added a commit that referenced this pull request Feb 28, 2022
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Feb 28, 2022
@mdelapenya mdelapenya mentioned this pull request Feb 28, 2022
8 tasks
mdelapenya added a commit that referenced this pull request Feb 28, 2022
* ci: use withAPMEnv (#1917)

* feat: partial backport for (#1628)

* chore: define variable for BeatsLocalPath

* fix: update path initialisation in unit tests

* chore: pass inline env vars to commands

Co-authored-by: Victor Martinez <[email protected]>

Co-authored-by: Victor Martinez <[email protected]>

* feat: export Fetch&Download methods in the /pkg directory (#1943)

* chore: copy internal's version files into the exported pkg public package

* chore: run unit tests from top-level goal

* chore: use public package instead of the internal one

* chore: remove old internal files for habdling downloads

* fix: update missing references

* Update `fetchBeatsBinary` to be reused in elastic-agent-poc (#1984)

* update func

* fix path

* work on download

* small fix

* remove test

* add sha to google

* fix typo

* add comment

* ci: increase log rotation (#2138)

* chore: increase build timeout to 90 minutes (#2139)

* feat: support downloading project artifacts for the new bucket layout (#2172)

* feat: support for the new bucket structure

* feat: calculate bucket URLs using resolvers

* chore: support for legacy Beats

Old PRs needs to be tested and the binaries could not exist in the new layout

* chore: support looking up the bucket in up-to 3 locations

1. new project layout
2. new beats layout
3. legacy beats layout

* chore: simplify boolean logic

* fix: pass worker environment for versions to the VMs

* fix: predefine kibana version

* fix: remove extra char

* fix: remove extra char

* chore: log resolvers

* chore: use new project method when fetching artifacts

* fix: pass stack version to stack deployment

* fix: use artifact to check for ubi8 variant

* chore: improve logs in resolvers

* fix: apply variants to project resolver

Ubi8 is a valid variant for elastic-agent

* chore: use Stack version for the dependant beats

In the running-on-top-of-beats feature file, the code installs some Beats
and we do not want to use the given SHA, because elastic-agent now lives
in a separate repo, therefore they do not share commit SHAs

* fix: use fleet-ci bucket for elastic-agent and fleet-server

* chore: look up both CI buckets

* chore: make useCISnapshots configurable on downloads

* chore: background processes should not use CI snapshots

* feat: separate elastic-agent version from beats version

* chore: extract useCISnapshots to a function

* chore: use Github_Check_Repo to identify where the Git commit lives

* fix: k8s-autodiscover lives in both worlds

* fix: missing package

* fix: use snapshot version in k8s-autodiscover

* fix: missing import

Co-authored-by: Victor Martinez <[email protected]>
Co-authored-by: Mariana Dima <[email protected]>
mdelapenya added a commit that referenced this pull request Feb 28, 2022
@mdelapenya mdelapenya deleted the increase-build-time branch March 9, 2022 06:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant