Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

fix: build each repository in the right branch #1631

Merged

Conversation

mdelapenya
Copy link
Contributor

What does this PR do?

This PR builds the affected repos in the right branches:

  • fleet-server: if there is a payload comming from a PR in the repo (via GH comment), it will build the 'PR/#ID' branch. Same if it's manually triggered using a PR ID as input paramenter. If a branch is used as input parameter (i.e. master, 7.16, 7.x) the the branch will be used as is.
  • beats: it will use what comes in the $BASE_REF variable, which is set in the first stage of the pipeline, within the getE2EBaseBranch() helper method. This method will internally set the env var to the baseRef attribute of the payload retrieved by our API call, which uses what comes from the webhook or in the input parameter. If a branch is used as an input parameter, it will build the same Beats branch.

Why is it important?

Build what is right

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the Unit tests (make unit-test), and they are passing locally
  • I have run the End-2-End tests for the suite I'm working on, and they are passing locally
  • I have noticed new Go dependencies (run make notice in the proper directory)

How to test this PR

Manually trigger the https://beats-ci.elastic.co/job/e2e-tests/job/e2e-testing-fleet-server/ job, using a fleet-server PR (or a branch) as parameter.

Related issues

@mdelapenya mdelapenya self-assigned this Oct 1, 2021
@mdelapenya mdelapenya requested a review from a team October 1, 2021 14:03
@mdelapenya mdelapenya marked this pull request as ready for review October 1, 2021 14:05
@mdelapenya
Copy link
Contributor Author

Merging, as it's not affecting the test suite

@mdelapenya mdelapenya merged commit 5111883 into elastic:master Oct 1, 2021
@elasticmachine
Copy link
Contributor

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-01T14:04:12.506+0000

  • Duration: 2 min 24 sec

  • Commit: 777108a

Steps errors 2

Expand to view the steps failures

Git fetch
  • Took 0 min 1 sec . View more details here
  • Description: git fetch https://${GIT_USERNAME}:${GIT_PASSWORD}@github.com/elastic/e2e-testing.git +refs/pull/*/head:refs/remotes/origin/pr/* > fetch.log 2>&1
Archive the artifacts
  • Took 0 min 1 sec . View more details here
  • Description: fetch.log

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@mdelapenya mdelapenya deleted the fix-git-checkout-regular-pipelines branch October 1, 2021 14:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants