Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APM Guide #2246

Merged
merged 4 commits into from
Oct 15, 2021
Merged

Add APM Guide #2246

merged 4 commits into from
Oct 15, 2021

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Oct 13, 2021

MERGE AFTER elastic/apm-server#6287

@bmorelli25 bmorelli25 requested review from gtback and a team October 13, 2021 00:45
@bmorelli25 bmorelli25 self-assigned this Oct 13, 2021
Copy link
Member

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM. It seems like the plan you have described in elastic/apm-server#6287 makes sense. Changing the chunk level can have unexpected consequences, but it seems like you've prepared for those.

conf.yaml Outdated Show resolved Hide resolved
doc_build_aliases.sh Show resolved Hide resolved
Co-authored-by: Greg Back <[email protected]>
Copy link
Member

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the builds pass

doc_build_aliases.sh Outdated Show resolved Hide resolved
conf.yaml Outdated Show resolved Hide resolved
conf.yaml Outdated Show resolved Hide resolved
Revert chunk level change on deprecated books
@bmorelli25 bmorelli25 merged commit 3277515 into elastic:master Oct 15, 2021
@bmorelli25 bmorelli25 deleted the add-new-apm-book branch October 15, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants