Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copy-as-curl should include content-type #143

Closed
clintongormley opened this issue Jan 20, 2017 · 2 comments
Closed

copy-as-curl should include content-type #143

clintongormley opened this issue Jan 20, 2017 · 2 comments
Labels
enhancement Something we'd like to improve

Comments

@clintongormley
Copy link
Contributor

With elastic/elasticsearch#22691, the content-type header will become mandatory for HTTP requests with bodies. copy-as-curl should be updated to include that header.

/cc @nik9000 in case you pick it up before i do
@clintongormley clintongormley added the enhancement Something we'd like to improve label Jan 20, 2017
@nik9000
Copy link
Member

nik9000 commented Jan 20, 2017

/cc @nik9000 in case you pick it up before i do

I think I might be able to grab it now if you like.

nik9000 added a commit to nik9000/docs that referenced this issue Jan 20, 2017
@nik9000
Add Content-Type header to COPY AS CURL
bff2814 
Adds the `Content-Type: application/json` header to the curl
request generated by the `COPY AS CURL` links if the request
has a body.

Closes elastic#143
@nik9000 nik9000 mentioned this issue Jan 20, 2017
Merged
@clintongormley
Copy link
Contributor Author

thanks @nik9000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Something we'd like to improve
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clintongormley @nik9000