Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule executions #335

Merged
merged 4 commits into from
Feb 10, 2025
Merged

Rule executions #335

merged 4 commits into from
Feb 10, 2025

Conversation

natasha-moore-elastic
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic commented Feb 5, 2025

  • Adds content to the Troubleshoot > Security > Detection rules page.
  • Adds content to the Solutions and use cases > Security > Detections and alerts > Monitor rule executions page.
  • Removes raw migrated files for monitoring rule executions and detection rules troubleshooting since they're not used elsewhere.
  • Updates anchor links that pointed to incorrect location of troubleshooting content.

Previews:

@natasha-moore-elastic natasha-moore-elastic requested review from marciw and a team February 10, 2025 13:34
marciw
marciw previously approved these changes Feb 10, 2025
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great with the exception of some unrendered attributed


% Internal links rely on the following IDs being on this page (e.g. as a heading ID, paragraph ID, etc):
::::{dropdown} {ml-cap} rule is failing and a required {{ml}} job is stopped
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The attributes are not rendering as expected here. I'm not sure what the best approach is but maybe hard coding the values?

Copy link
Contributor Author

@natasha-moore-elastic natasha-moore-elastic Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's a known issue, so probably OK to leave as is until it's fixed. Edit: Looks like it was fixed a couple of hours ago so will probably be in the next release of docs-builder :)
Saying that, {ml-cap} should actually be {{ml-cap}} because the attribute syntax requires double brackets, so good catch!

@natasha-moore-elastic natasha-moore-elastic merged commit 4e69798 into main Feb 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants