Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add empty technique array to rules #828

Merged
merged 3 commits into from
Jan 11, 2021
Merged

Add empty technique array to rules #828

merged 3 commits into from
Jan 11, 2021

Conversation

brokensound77
Copy link
Contributor

Issues

Resolves #812

Summary

Inserts empty array into rule payload threat mapping where technique is not defined

@brokensound77 brokensound77 added the python Internal python for the repository label Jan 11, 2021
rw-access
rw-access approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@rw-access rw-access left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good

detection_rules/rule.py Outdated Show resolved Hide resolved
detection_rules/rule.py
if include_version:
payload['version'] = self.get_version()

if embed_metadata:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, I dig this

@brokensound77 brokensound77 merged commit 6177458 into elastic:7.11 Jan 11, 2021
@brokensound77 brokensound77 mentioned this pull request Jan 11, 2021
Closed
@brokensound77 brokensound77 mentioned this pull request Jan 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@threat-punter threat-punter threat-punter approved these changes

@rw-access rw-access rw-access approved these changes

Assignees
No one assigned
Labels
python Internal python for the repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brokensound77 @rw-access @threat-punter