Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix 7.11 -> 7.10 ATT&CK downgrade logic for optional techiques #736

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

rw-access
Copy link
Contributor

@rw-access rw-access commented Dec 18, 2020

Issues

A user found that some of the latest Sunburst rules weren't working with Kibana upload. The biggest reason is the downgrade process from 7.11 to 7.10.

Summary

We still have an issue where some new EQL functionality won't work properly in the detection engine (e.g. process.name : ("a", "b", "c") syntax and : with wildcards aren't supported.

The ATT&CK subtechnique process seemed to be working, but I didn't update the downgrade process for optional techniques, which was new in #727.

We'll merge 7.11 into main after this is merged.

@rw-access rw-access added bug Something isn't working python Internal python for the repository labels Dec 18, 2020
Copy link
Contributor

@brokensound77 brokensound77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

Copy link
Contributor

@threat-punter threat-punter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@rw-access rw-access merged commit 7dcb666 into 7.11 Dec 18, 2020
@rw-access rw-access deleted the bug/attack-downgrade branch December 18, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python Internal python for the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants