Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows DNS server vulnerability (CVE-2020-1350) rules #69

Merged
merged 15 commits into from
Jul 17, 2020

Conversation

brokensound77
Copy link
Contributor

@brokensound77 brokensound77 commented Jul 16, 2020

Issues

resolves #68

Summary

This creates three rules related to CVE-2020-1350 - Windows DNS server vulnerability.

  • Unusual Child Process of dns.exe (process)
  • Unusual File Modification by dns.exe (file)
  • Malicious DNS SIG Request (network)

Only the network rule is specific to the CVE, with the others resilient enough to identify anomalous behavior via any manipulation of the service. While the rules will help detect potential exploitation of the CVE, they are written to detect anomalies around the DNS server in general.

@brokensound77 brokensound77 added v7.10.0 Rule: New Proposal for new rule OS: Windows windows related rules labels Jul 16, 2020
[[rule.threat]]
framework = "MITRE ATT&CK"
[[rule.threat.technique]]
id = "T1133"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T1569 System Services would likely be a better fit here, but we need to update mapping first, which may need some refactoring to account for sub-techniques

Copy link
Contributor

@rw-access rw-access Jul 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep. adding xref to #52

@brokensound77
Copy link
Contributor Author

We should add triage and any relevant intel to notes as well @dstepanic17

Co-authored-by: Andrew Pease <[email protected]>
Co-authored-by: Andrew Pease <[email protected]>
@dstepanic dstepanic changed the title Windows DNS server vulnerability (CVE-2020-1315) rules Windows DNS server vulnerability (CVE-2020-1350) rules Jul 17, 2020
risk_score = 73
rule_id = "c7ce36c0-32ff-4f9a-bfc2-dcb242bf99f9"
severity = "high"
tags = ["CVE-2020-1350", "Elastic", "Windows"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these tags populate in the UI. Do we want to have this specific CVE tag in the UI as opposed to just the standard “Windows” tag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

Yep, I think so. Since we tend to normally target behavior rather than specific vulnerabilities, rules specific to a CVE will be less frequent. In cases where the CVE is a 10 and has significant impact, if it makes sense to have a rule, I think it makes sense to tag the CVE it may be more commonly known by.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should treat tags as one-offs, but more as ways to build medium-large groups of rules.

I think we should instead support more threat frameworks than just ATT&CK

Suggested change
tags = ["CVE-2020-1350", "Elastic", "Windows"]
tags = ["Elastic", "Windows"]

Copy link
Contributor

@bm11100 bm11100 Jul 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree @rw-access. I think it could get a bit messy and dated over an extended period of time to have one off tags, unless we had a better way to sort or visualize tags in the UI.

Copy link
Contributor Author

@brokensound77 brokensound77 Jul 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had a discussion and have decided to remove any mention of CVE from tags altogether. We still have to come to a decision on when we want to associate a CVE to a rule in general (only rules specific to a CVE, only CVE 10, etc.), but once we figure that it, it would most likely be better fit within the threat array, such as

threat = [{
    "framework": "CVE",
    "cve_list": [
        {
            "ID": "2020-1350",
            "CVSS": 10
        }
    ]
}]

+- any other relevant fields we would want to build into that structure. The API would need updating to support this first as well (cc @spong)

Once we agree on structure, we can create an issue

Copy link
Contributor

@peasead peasead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll let others comment on the endpoint rules.

Copy link
Contributor

@rw-access rw-access left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the verbiage for the description, otherwise lgtm

@brokensound77 brokensound77 merged commit 1cfb8f9 into elastic:main Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS: Windows windows related rules Rule: New Proposal for new rule v7.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Rule] Detect SIGRed DNS Exploit
6 participants