-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rule Tuning] Remove Trailing Comma in AWS IAM User Created Access Keys For Another User
#4292
Merged
terrancedejesus
merged 1 commit into
main
from
rule-tuning-remove-trailing-comma-aws-esql
Dec 10, 2024
Merged
[Rule Tuning] Remove Trailing Comma in AWS IAM User Created Access Keys For Another User
#4292
terrancedejesus
merged 1 commit into
main
from
rule-tuning-remove-trailing-comma-aws-esql
Dec 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrancedejesus
added
Integration: AWS
AWS related rules
Domain: Cloud
Rule: Tuning
tweaking or tuning an existing rule
labels
Dec 10, 2024
terrancedejesus
requested review from
imays11,
Aegrah and
shashank-elastic
and removed request for
imays11
December 10, 2024 14:19
Rule: Tuning - GuidelinesThese guidelines serve as a reminder set of considerations when tuning an existing rule. Documentation and Context
Rule Metadata Checks
Testing and Validation
|
Mikaayenson
approved these changes
Dec 10, 2024
shashank-elastic
approved these changes
Dec 10, 2024
terrancedejesus
deleted the
rule-tuning-remove-trailing-comma-aws-esql
branch
December 10, 2024 14:27
protectionsmachine
pushed a commit
that referenced
this pull request
Dec 10, 2024
(cherry picked from commit e6012b1)
protectionsmachine
pushed a commit
that referenced
this pull request
Dec 10, 2024
(cherry picked from commit e6012b1)
protectionsmachine
pushed a commit
that referenced
this pull request
Dec 10, 2024
(cherry picked from commit e6012b1)
protectionsmachine
pushed a commit
that referenced
this pull request
Dec 10, 2024
(cherry picked from commit e6012b1)
protectionsmachine
pushed a commit
that referenced
this pull request
Dec 10, 2024
(cherry picked from commit e6012b1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport: auto
Domain: Cloud
Integration: AWS
AWS related rules
Rule: Tuning
tweaking or tuning an existing rule
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue link(s):
Summary - What I changed
Removes trailing comma from
KEEP
command in AWS rule. Identified via https://elastic.slack.com/archives/C02HA9E8221/p1733783804664949How To Test
Checklist
bug
,enhancement
,schema
,maintenance
,Rule: New
,Rule: Deprecation
,Rule: Tuning
,Hunt: New
, orHunt: Tuning
so guidelines can be generatedmeta:rapid-merge
label if planning to merge within 24 hoursContributor checklist