Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rule Tuning] Kernel Module Removal #4269

Merged
merged 2 commits into from
Nov 25, 2024
Merged

[Rule Tuning] Kernel Module Removal #4269

merged 2 commits into from
Nov 25, 2024

Conversation

Aegrah
Copy link
Contributor

@Aegrah Aegrah commented Nov 15, 2024

Summary

This rule had a bad update_date.

@protectionsmachine
Copy link
Collaborator

Rule: Tuning - Guidelines

These guidelines serve as a reminder set of considerations when tuning an existing rule.

Documentation and Context

  • Detailed description of the suggested changes.
  • Provide example JSON data or screenshots.
  • Provide evidence of reducing benign events mistakenly identified as threats (False Positives).
  • Provide evidence of enhancing detection of true threats that were previously missed (False Negatives).
  • Provide evidence of optimizing resource consumption and execution time of detection rules (Performance).
  • Provide evidence of specific environment factors influencing customized rule tuning (Contextual Tuning).
  • Provide evidence of improvements made by modifying sensitivity by changing alert triggering thresholds (Threshold Adjustments).
  • Provide evidence of refining rules to better detect deviations from typical behavior (Behavioral Tuning).
  • Provide evidence of improvements of adjusting rules based on time-based patterns (Temporal Tuning).
  • Provide reasoning of adjusting priority or severity levels of alerts (Severity Tuning).
  • Provide evidence of improving quality integrity of our data used by detection rules (Data Quality).
  • Ensure the tuning includes necessary updates to the release documentation and versioning.

Rule Metadata Checks

  • updated_date matches the date of tuning PR merged.
  • min_stack_version should support the widest stack versions.
  • name and description should be descriptive and not include typos.
  • query should be inclusive, not overly exclusive. Review to ensure the original intent of the rule is maintained.

Testing and Validation

  • Validate that the tuned rule's performance is satisfactory and does not negatively impact the stack.
  • Ensure that the tuned rule has a low false positive rate.

@Mikaayenson
Copy link
Contributor

Thanks @Aegrah

@Aegrah Aegrah merged commit 4e28895 into main Nov 25, 2024
9 checks passed
@Aegrah Aegrah deleted the fix-update-date branch November 25, 2024 20:13
protectionsmachine pushed a commit that referenced this pull request Nov 25, 2024
Co-authored-by: Mika Ayenson <[email protected]>

(cherry picked from commit 4e28895)
protectionsmachine pushed a commit that referenced this pull request Nov 25, 2024
Co-authored-by: Mika Ayenson <[email protected]>

(cherry picked from commit 4e28895)
protectionsmachine pushed a commit that referenced this pull request Nov 25, 2024
Co-authored-by: Mika Ayenson <[email protected]>

(cherry picked from commit 4e28895)
protectionsmachine pushed a commit that referenced this pull request Nov 25, 2024
Co-authored-by: Mika Ayenson <[email protected]>

(cherry picked from commit 4e28895)
protectionsmachine pushed a commit that referenced this pull request Nov 25, 2024
Co-authored-by: Mika Ayenson <[email protected]>

(cherry picked from commit 4e28895)
protectionsmachine pushed a commit that referenced this pull request Nov 25, 2024
Co-authored-by: Mika Ayenson <[email protected]>

(cherry picked from commit 4e28895)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants