-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account for CCS '::' index pattern #4258
Conversation
Enhancement - GuidelinesThese guidelines serve as a reminder set of considerations when addressing adding a feature to the code. Documentation and Context
Code Standards and Practices
Testing
Additional Checks
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 Manual review, looks good to me! 👍
The .replace
approach should function as both ":" and "::" are reserved for CCS at this time. However, this will need to be revisited should the ":" be reserved for something else in the index.
# e.g. mycluster:logs-* -> logs-* | ||
for index in indexes: | ||
if "beat-*" in index: | ||
index_parts = index.split(':', 1) | ||
index_parts = index.replace('::', ':').split(':', 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesnt look like an issue, but in the kibana pr/issue, did it reference beat indexes would have this pattern?
Can you double check the 4 dac export/import commands to ensure this doesn't introduce errors? |
Testing Updated |
(cherry picked from commit 04e1fc1)
(cherry picked from commit 04e1fc1)
(cherry picked from commit 04e1fc1)
(cherry picked from commit 04e1fc1)
(cherry picked from commit 04e1fc1)
(cherry picked from commit 04e1fc1)
Pull Request
Issue link(s): #4158
Summary - What I changed
::
delimiter:
delimiter and replace any occurrence of::
to:
How To Test
::
delimiterRule Details
view-rule Details
:
delimiterRule Details
view-rule Details
Testing 4 DAC export/import commands - #3509
Successful Import of Rule with Run Time Field
AutoGen Schema populated successfully
Successful Export of Rule with Run Time Field
Exported Rule with CSS indices "::" nothing was replaced in original file
Successful Export of Rule with Run Time Field From Kibana
Based on the Fix #3984 we are using the -ac flag.
Successful Import of Rule with Run Time Field To Kibana
make test-cli
Snippet of the run
make test-rmote-cli
bug
,enhancement
,schema
,maintenance
,Rule: New
,Rule: Deprecation
,Rule: Tuning
,Hunt: New
, orHunt: Tuning
so guidelines can be generatedmeta:rapid-merge
label if planning to merge within 24 hoursContributor checklist