-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] Update the release versioning process and workflow #4257
Conversation
Enhancement - GuidelinesThese guidelines serve as a reminder set of considerations when addressing adding a feature to the code. Documentation and Context
Code Standards and Practices
Testing
Additional Checks
|
…tion-rules into update_versioning_workflow
echo "Detected version: $version" | ||
git tag -a "v$version" -m "Release version $version" | ||
git push origin "v$version" | ||
|
||
- name: Run Release Drafter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@traut was going to gate this behind only major/minor tags, but since its only generating a draft, I now dont think we need to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes discussed on discussion call, looks good
Just typing the process as I see it to confirm, I think the output of the update will create a tag on any version change to the root pyproject.toml, and as such the prior release pipeline will function as intended, rather this will address the issue where our tags would not match the pyproject.toml on the draft releases that were created. Good peer review, LGTM 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's go!
(cherry picked from commit c615df6)
(cherry picked from commit c615df6)
(cherry picked from commit c615df6)
(cherry picked from commit c615df6)
(cherry picked from commit c615df6)
(cherry picked from commit c615df6)
Pull Request
Issue link(s):
Summary - What I changed
How To Test
Checklist
bug
,enhancement
,schema
,maintenance
,Rule: New
,Rule: Deprecation
,Rule: Tuning
,Hunt: New
, orHunt: Tuning
so guidelines can be generatedmeta:rapid-merge
label if planning to merge within 24 hours