-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Rule] Adding Coverage for AWS Discovery API Calls via CLI from a Single Resource
#4246
Merged
terrancedejesus
merged 14 commits into
main
from
new-rule-aws-potential-discovery-enumeration-via-cli
Nov 6, 2024
Merged
[New Rule] Adding Coverage for AWS Discovery API Calls via CLI from a Single Resource
#4246
terrancedejesus
merged 14 commits into
main
from
new-rule-aws-potential-discovery-enumeration-via-cli
Nov 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrancedejesus
added
Integration: AWS
AWS related rules
Domain: Cloud
Rule: New
Proposal for new rule
labels
Nov 4, 2024
Rule: New - GuidelinesThese guidelines serve as a reminder set of considerations when proposing a new rule. Documentation and Context
Rule Metadata Checks
New BBR Rules
Testing and Validation
|
terrancedejesus
requested review from
w0rk3r,
DefSecSentinel,
imays11,
Samirbous,
Aegrah,
shashank-elastic and
eric-forte-elastic
November 4, 2024 21:25
terrancedejesus
commented
Nov 4, 2024
rules/integrations/aws/discovery_ec2_multi_region_describe_instances.toml
Show resolved
Hide resolved
imays11
reviewed
Nov 5, 2024
rules/integrations/aws/discovery_ec2_multiple_discovery_api_calls_via_cli.toml
Show resolved
Hide resolved
imays11
reviewed
Nov 5, 2024
rules/integrations/aws/discovery_ec2_multiple_discovery_api_calls_via_cli.toml
Show resolved
Hide resolved
imays11
reviewed
Nov 5, 2024
rules/integrations/aws/discovery_ec2_multiple_discovery_api_calls_via_cli.toml
Outdated
Show resolved
Hide resolved
Aegrah
approved these changes
Nov 5, 2024
rules/integrations/aws/discovery_ec2_multiple_discovery_api_calls_via_cli.toml
Outdated
Show resolved
Hide resolved
terrancedejesus
commented
Nov 5, 2024
rules/integrations/aws/discovery_ec2_multiple_discovery_api_calls_via_cli.toml
Outdated
Show resolved
Hide resolved
shashank-elastic
approved these changes
Nov 6, 2024
imays11
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
terrancedejesus
deleted the
new-rule-aws-potential-discovery-enumeration-via-cli
branch
November 6, 2024 17:14
protectionsmachine
pushed a commit
that referenced
this pull request
Nov 6, 2024
…a Single Resource` (#4246) * adding new rule 'AWS Multiple Discovery API Calls via CLI from a Single Resource' * adjusted name * adjusted ESQL functions * changed query comment * Update rules/integrations/aws/discovery_ec2_multiple_discovery_api_calls_via_cli.toml * adjusted query * added min-stack * adjusted query (cherry picked from commit c602042)
protectionsmachine
pushed a commit
that referenced
this pull request
Nov 6, 2024
…a Single Resource` (#4246) * adding new rule 'AWS Multiple Discovery API Calls via CLI from a Single Resource' * adjusted name * adjusted ESQL functions * changed query comment * Update rules/integrations/aws/discovery_ec2_multiple_discovery_api_calls_via_cli.toml * adjusted query * added min-stack * adjusted query (cherry picked from commit c602042)
protectionsmachine
pushed a commit
that referenced
this pull request
Nov 6, 2024
…a Single Resource` (#4246) * adding new rule 'AWS Multiple Discovery API Calls via CLI from a Single Resource' * adjusted name * adjusted ESQL functions * changed query comment * Update rules/integrations/aws/discovery_ec2_multiple_discovery_api_calls_via_cli.toml * adjusted query * added min-stack * adjusted query (cherry picked from commit c602042)
protectionsmachine
pushed a commit
that referenced
this pull request
Nov 6, 2024
…a Single Resource` (#4246) * adding new rule 'AWS Multiple Discovery API Calls via CLI from a Single Resource' * adjusted name * adjusted ESQL functions * changed query comment * Update rules/integrations/aws/discovery_ec2_multiple_discovery_api_calls_via_cli.toml * adjusted query * added min-stack * adjusted query (cherry picked from commit c602042)
protectionsmachine
pushed a commit
that referenced
this pull request
Nov 6, 2024
…a Single Resource` (#4246) * adding new rule 'AWS Multiple Discovery API Calls via CLI from a Single Resource' * adjusted name * adjusted ESQL functions * changed query comment * Update rules/integrations/aws/discovery_ec2_multiple_discovery_api_calls_via_cli.toml * adjusted query * added min-stack * adjusted query (cherry picked from commit c602042)
protectionsmachine
pushed a commit
that referenced
this pull request
Nov 6, 2024
…a Single Resource` (#4246) * adding new rule 'AWS Multiple Discovery API Calls via CLI from a Single Resource' * adjusted name * adjusted ESQL functions * changed query comment * Update rules/integrations/aws/discovery_ec2_multiple_discovery_api_calls_via_cli.toml * adjusted query * added min-stack * adjusted query (cherry picked from commit c602042)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue link(s):
Summary - What I changed
Added detection coverage for
AWS Discovery API Calls via CLI from a Single Resource
.Detects when a single AWS resource is running multiple
Describe
andList
API calls in a 30-second window. Thisbehavior could indicate an actor attempting to discover the AWS infrastructure using compromised credentials or a
compromised instance. Adversaries may use this information to identify potential targets for further exploitation or to
gain a better understanding of the target's infrastructure.
How To Test
Checklist
bug
,enhancement
,schema
,Rule: New
,Rule: Deprecation
,Rule: Tuning
,Hunt: New
, orHunt: Tuning
so guidelines can be generatedmeta:rapid-merge
label if planning to merge within 24 hoursContributor checklist