-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rule Tuning] Tuning AWS STS Temporary Credentials via AssumeRole
#4228
Merged
terrancedejesus
merged 13 commits into
main
from
rule-tuning-aws-sts-temporary-credentials-via-assumedrole
Nov 6, 2024
Merged
[Rule Tuning] Tuning AWS STS Temporary Credentials via AssumeRole
#4228
terrancedejesus
merged 13 commits into
main
from
rule-tuning-aws-sts-temporary-credentials-via-assumedrole
Nov 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rule: New - GuidelinesThese guidelines serve as a reminder set of considerations when proposing a new rule. Documentation and Context
Rule Metadata Checks
New BBR Rules
Testing and Validation
|
AWS STS Temporary Credentials via AssumeRole
terrancedejesus
commented
Nov 1, 2024
rules/integrations/aws/privilege_escalation_sts_temp_creds_via_assume_role.toml
Outdated
Show resolved
Hide resolved
…_assume_role.toml
Aegrah
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rules/integrations/aws/privilege_escalation_sts_temp_creds_via_assume_role.toml
Outdated
Show resolved
Hide resolved
…_assume_role.toml Co-authored-by: Ruben Groenewoud <[email protected]>
imays11
reviewed
Nov 5, 2024
rules/integrations/aws/privilege_escalation_sts_temp_creds_via_assume_role.toml
Outdated
Show resolved
Hide resolved
imays11
reviewed
Nov 5, 2024
rules/integrations/aws/privilege_escalation_sts_temp_creds_via_assume_role.toml
Outdated
Show resolved
Hide resolved
rules/integrations/aws/privilege_escalation_sts_temp_creds_via_assume_role.toml
Show resolved
Hide resolved
shashank-elastic
approved these changes
Nov 6, 2024
imays11
reviewed
Nov 6, 2024
rules/integrations/aws/privilege_escalation_role_assumption_by_service.toml
Outdated
Show resolved
Hide resolved
imays11
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
protectionsmachine
pushed a commit
that referenced
this pull request
Nov 6, 2024
…4228) * tuning 'AWS STS Temporary Credentials via AssumeRole' * linted; adjusted OR in quer * added investigation guide * Update rules/integrations/aws/privilege_escalation_sts_temp_creds_via_assume_role.toml * Update rules/integrations/aws/privilege_escalation_sts_temp_creds_via_assume_role.toml Co-authored-by: Ruben Groenewoud <[email protected]> * added new rule 'AWS STS Role Assumption by User' * adjusted UUID * Update rules/integrations/aws/privilege_escalation_role_assumption_by_service.toml --------- Co-authored-by: Ruben Groenewoud <[email protected]> Co-authored-by: Isai <[email protected]> (cherry picked from commit ef6344f)
protectionsmachine
pushed a commit
that referenced
this pull request
Nov 6, 2024
…4228) * tuning 'AWS STS Temporary Credentials via AssumeRole' * linted; adjusted OR in quer * added investigation guide * Update rules/integrations/aws/privilege_escalation_sts_temp_creds_via_assume_role.toml * Update rules/integrations/aws/privilege_escalation_sts_temp_creds_via_assume_role.toml Co-authored-by: Ruben Groenewoud <[email protected]> * added new rule 'AWS STS Role Assumption by User' * adjusted UUID * Update rules/integrations/aws/privilege_escalation_role_assumption_by_service.toml --------- Co-authored-by: Ruben Groenewoud <[email protected]> Co-authored-by: Isai <[email protected]> (cherry picked from commit ef6344f)
protectionsmachine
pushed a commit
that referenced
this pull request
Nov 6, 2024
…4228) * tuning 'AWS STS Temporary Credentials via AssumeRole' * linted; adjusted OR in quer * added investigation guide * Update rules/integrations/aws/privilege_escalation_sts_temp_creds_via_assume_role.toml * Update rules/integrations/aws/privilege_escalation_sts_temp_creds_via_assume_role.toml Co-authored-by: Ruben Groenewoud <[email protected]> * added new rule 'AWS STS Role Assumption by User' * adjusted UUID * Update rules/integrations/aws/privilege_escalation_role_assumption_by_service.toml --------- Co-authored-by: Ruben Groenewoud <[email protected]> Co-authored-by: Isai <[email protected]> (cherry picked from commit ef6344f)
protectionsmachine
pushed a commit
that referenced
this pull request
Nov 6, 2024
…4228) * tuning 'AWS STS Temporary Credentials via AssumeRole' * linted; adjusted OR in quer * added investigation guide * Update rules/integrations/aws/privilege_escalation_sts_temp_creds_via_assume_role.toml * Update rules/integrations/aws/privilege_escalation_sts_temp_creds_via_assume_role.toml Co-authored-by: Ruben Groenewoud <[email protected]> * added new rule 'AWS STS Role Assumption by User' * adjusted UUID * Update rules/integrations/aws/privilege_escalation_role_assumption_by_service.toml --------- Co-authored-by: Ruben Groenewoud <[email protected]> Co-authored-by: Isai <[email protected]> (cherry picked from commit ef6344f)
protectionsmachine
pushed a commit
that referenced
this pull request
Nov 6, 2024
…4228) * tuning 'AWS STS Temporary Credentials via AssumeRole' * linted; adjusted OR in quer * added investigation guide * Update rules/integrations/aws/privilege_escalation_sts_temp_creds_via_assume_role.toml * Update rules/integrations/aws/privilege_escalation_sts_temp_creds_via_assume_role.toml Co-authored-by: Ruben Groenewoud <[email protected]> * added new rule 'AWS STS Role Assumption by User' * adjusted UUID * Update rules/integrations/aws/privilege_escalation_role_assumption_by_service.toml --------- Co-authored-by: Ruben Groenewoud <[email protected]> Co-authored-by: Isai <[email protected]> (cherry picked from commit ef6344f)
protectionsmachine
pushed a commit
that referenced
this pull request
Nov 6, 2024
…4228) * tuning 'AWS STS Temporary Credentials via AssumeRole' * linted; adjusted OR in quer * added investigation guide * Update rules/integrations/aws/privilege_escalation_sts_temp_creds_via_assume_role.toml * Update rules/integrations/aws/privilege_escalation_sts_temp_creds_via_assume_role.toml Co-authored-by: Ruben Groenewoud <[email protected]> * added new rule 'AWS STS Role Assumption by User' * adjusted UUID * Update rules/integrations/aws/privilege_escalation_role_assumption_by_service.toml --------- Co-authored-by: Ruben Groenewoud <[email protected]> Co-authored-by: Isai <[email protected]> (cherry picked from commit ef6344f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport: auto
Domain: Cloud
Integration: AWS
AWS related rules
Rule: New
Proposal for new rule
Rule: Tuning
tweaking or tuning an existing rule
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue link(s):
Summary - What I changed
user.id
from query as it is not always present in event docs, causing false-negatives to occurNote
This rule is expected to still generate global false-positives based on context mainly existing in user agent, which is not reliable to filter on. For example, we could ignore all AWS-CLI and AWS-SDK and that would remove 80% of alert volume. However, it would also potentially introduce false-negatives where TAs abuse OOTB AWS CLI on EC2 instances as an example. As such we have added an investigation guide that suggests adding custom exceptions for user-agent or ARN specifically is verifiable.
How To Test
Checklist
bug
,enhancement
,schema
,Rule: New
,Rule: Deprecation
,Rule: Tuning
,Hunt: New
, orHunt: Tuning
so guidelines can be generatedmeta:rapid-merge
label if planning to merge within 24 hoursContributor checklist