-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rule Tuning] 3rd Party EDR - Add Crowdstrike FDR support - 1 #4220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w0rk3r
added
Rule: Tuning
tweaking or tuning an existing rule
OS: Windows
windows related rules
Domain: Endpoint
backport: auto
labels
Oct 31, 2024
w0rk3r
requested review from
Mikaayenson,
DefSecSentinel,
Samirbous,
Aegrah,
shashank-elastic and
terrancedejesus
October 31, 2024 13:24
Enhancement - GuidelinesThese guidelines serve as a reminder set of considerations when addressing adding a new schema feature to the code. Documentation and Context
Code Standards and Practices
Testing
Additional Schema Related Checks
|
Samirbous
approved these changes
Nov 1, 2024
Aegrah
approved these changes
Nov 1, 2024
Mikaayenson
approved these changes
Nov 4, 2024
protectionsmachine
pushed a commit
that referenced
this pull request
Nov 4, 2024
* [Rule Tuning] 3rd Party EDR - Add Crowdstrike FDR support - 1 * Update Integrations unit tests * Update test_all_rules.py Removed changes from: - rules/windows/collection_email_powershell_exchange_mailbox.toml - rules/windows/command_and_control_headless_browser.toml - rules/windows/command_and_control_rdp_tunnel_plink.toml - rules/windows/command_and_control_screenconnect_childproc.toml - rules/windows/command_and_control_tunnel_vscode.toml - rules/windows/credential_access_domain_backup_dpapi_private_keys.toml - rules/windows/credential_access_kirbi_file.toml - rules/windows/credential_access_relay_ntlm_auth_via_http_spoolss.toml - rules/windows/defense_evasion_disable_windows_firewall_rules_with_netsh.toml - rules/windows/defense_evasion_dotnet_compiler_parent_process.toml (selectively cherry picked from commit 81292ae)
protectionsmachine
pushed a commit
that referenced
this pull request
Nov 4, 2024
* [Rule Tuning] 3rd Party EDR - Add Crowdstrike FDR support - 1 * Update Integrations unit tests * Update test_all_rules.py Removed changes from: - rules/windows/collection_email_powershell_exchange_mailbox.toml - rules/windows/command_and_control_headless_browser.toml - rules/windows/command_and_control_rdp_tunnel_plink.toml - rules/windows/command_and_control_screenconnect_childproc.toml - rules/windows/command_and_control_tunnel_vscode.toml - rules/windows/credential_access_domain_backup_dpapi_private_keys.toml - rules/windows/credential_access_kirbi_file.toml - rules/windows/credential_access_relay_ntlm_auth_via_http_spoolss.toml - rules/windows/defense_evasion_disable_windows_firewall_rules_with_netsh.toml - rules/windows/defense_evasion_dotnet_compiler_parent_process.toml (selectively cherry picked from commit 81292ae)
protectionsmachine
pushed a commit
that referenced
this pull request
Nov 4, 2024
* [Rule Tuning] 3rd Party EDR - Add Crowdstrike FDR support - 1 * Update Integrations unit tests * Update test_all_rules.py Removed changes from: - rules/windows/collection_email_powershell_exchange_mailbox.toml - rules/windows/command_and_control_headless_browser.toml - rules/windows/command_and_control_rdp_tunnel_plink.toml - rules/windows/command_and_control_screenconnect_childproc.toml - rules/windows/command_and_control_tunnel_vscode.toml - rules/windows/credential_access_domain_backup_dpapi_private_keys.toml - rules/windows/credential_access_kirbi_file.toml - rules/windows/credential_access_relay_ntlm_auth_via_http_spoolss.toml - rules/windows/defense_evasion_disable_windows_firewall_rules_with_netsh.toml - rules/windows/defense_evasion_dotnet_compiler_parent_process.toml (selectively cherry picked from commit 81292ae)
protectionsmachine
pushed a commit
that referenced
this pull request
Nov 4, 2024
* [Rule Tuning] 3rd Party EDR - Add Crowdstrike FDR support - 1 * Update Integrations unit tests * Update test_all_rules.py Removed changes from: - rules/windows/collection_email_powershell_exchange_mailbox.toml - rules/windows/command_and_control_headless_browser.toml - rules/windows/command_and_control_rdp_tunnel_plink.toml - rules/windows/command_and_control_screenconnect_childproc.toml - rules/windows/command_and_control_tunnel_vscode.toml - rules/windows/credential_access_domain_backup_dpapi_private_keys.toml - rules/windows/credential_access_kirbi_file.toml - rules/windows/credential_access_relay_ntlm_auth_via_http_spoolss.toml - rules/windows/defense_evasion_disable_windows_firewall_rules_with_netsh.toml - rules/windows/defense_evasion_dotnet_compiler_parent_process.toml (selectively cherry picked from commit 81292ae)
protectionsmachine
pushed a commit
that referenced
this pull request
Nov 4, 2024
* [Rule Tuning] 3rd Party EDR - Add Crowdstrike FDR support - 1 * Update Integrations unit tests * Update test_all_rules.py (cherry picked from commit 81292ae)
protectionsmachine
pushed a commit
that referenced
this pull request
Nov 4, 2024
* [Rule Tuning] 3rd Party EDR - Add Crowdstrike FDR support - 1 * Update Integrations unit tests * Update test_all_rules.py (cherry picked from commit 81292ae)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport: auto
Domain: Endpoint
OS: Windows
windows related rules
python
Internal python for the repository
Rule: Tuning
tweaking or tuning an existing rule
schema
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Part of https://github.com/elastic/ia-trade-team/issues/242
Summary
Adjust simple (no sequence) rules to introduce support for Crowdstrike FDR. While full logic validation wasn't possible due to the lack of a test environment, the field population for each category was verified to ensure the data was correctly structured and populated as needed.
EDR field compatibility matrix may be of help to review, although the data provided by FDR is not consistent across event categories, and not even between event actions.