-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Rule] APT Package Manager Configuration File Creation #3739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aegrah
commented
Jun 6, 2024
terrancedejesus
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Added a question about adding APT itself to the list of exclusions.
Mikaayenson
approved these changes
Jun 7, 2024
protectionsmachine
pushed a commit
that referenced
this pull request
Jun 11, 2024
* [New Rule] APT Package Manager Configuration File Creation * Update rules/linux/persistence_apt_package_manager_file_creation.toml * Update persistence_apt_package_manager_file_creation.toml (cherry picked from commit 4003219)
protectionsmachine
pushed a commit
that referenced
this pull request
Jun 11, 2024
* [New Rule] APT Package Manager Configuration File Creation * Update rules/linux/persistence_apt_package_manager_file_creation.toml * Update persistence_apt_package_manager_file_creation.toml (cherry picked from commit 4003219)
protectionsmachine
pushed a commit
that referenced
this pull request
Jun 11, 2024
* [New Rule] APT Package Manager Configuration File Creation * Update rules/linux/persistence_apt_package_manager_file_creation.toml * Update persistence_apt_package_manager_file_creation.toml (cherry picked from commit 4003219)
protectionsmachine
pushed a commit
that referenced
this pull request
Jun 11, 2024
* [New Rule] APT Package Manager Configuration File Creation * Update rules/linux/persistence_apt_package_manager_file_creation.toml * Update persistence_apt_package_manager_file_creation.toml (cherry picked from commit 4003219)
protectionsmachine
pushed a commit
that referenced
this pull request
Jun 11, 2024
* [New Rule] APT Package Manager Configuration File Creation * Update rules/linux/persistence_apt_package_manager_file_creation.toml * Update persistence_apt_package_manager_file_creation.toml (cherry picked from commit 4003219)
protectionsmachine
pushed a commit
that referenced
this pull request
Jun 11, 2024
* [New Rule] APT Package Manager Configuration File Creation * Update rules/linux/persistence_apt_package_manager_file_creation.toml * Update persistence_apt_package_manager_file_creation.toml (cherry picked from commit 4003219)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Research related to this PR is conducted and documented in https://github.com/elastic/ia-trade-team/issues/374. This issue also contains the query + validation aspect.
This PR:
/etc/apt/apt.conf.d/
directory, with a robust set of exclusions built-in by default.Only TPs in testing stack, 9 hits last 1 year in telemetry, all cases to look at.