[Rule Tuning] Windows BBR Tuning - 1 #3380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w0rk3r
added
Rule: Tuning
w0rk3r
requested review from
brokensound77,
DefSecSentinel,
imays11,
Samirbous,
Aegrah,
shashank-elastic and
terrancedejesus
Aegrah
approved these changes
Jan 11, 2024
| @@ -37,7 +37,7 @@ timestamp_override = "event.ingested" | |||
| type = "eql" | |||
|
|
|||
| query = ''' | |||
| file where event.type in ("creation", "change") and | |||
| file where event.type in ("creation", "change") and process.executable != null and not user.id : "S-1-5-18" and | |||
There was a problem hiding this comment.
I don't think we should tune this rule. The intent is to identify any file that is compressed without depending on the file extension. It should be used as contextual, which is why it is a BBR. Its need was based on identified gaps of other detection methods for compression which were more brittle
There was a problem hiding this comment.
The problem is matching on system functionality instead of user behaviors, like the firefox one represents 20% of the volume (2M alerts if I remember correctly), just related to cache files and other browser-related stuff
| @@ -35,13 +35,16 @@ file where host.os.type == "windows" and event.type == "creation" and | |||
|
|
|||
| ( | |||
| ( | |||
| process.name : "System" or | |||
There was a problem hiding this comment.
should we be tuning this one either, based on description?
There was a problem hiding this comment.
I think any rule can use some tuning to exclude common system activities
terrancedejesus
approved these changes
Feb 1, 2024
Samirbous
approved these changes
Feb 5, 2024
protectionsmachine
pushed a commit
that referenced
this pull request
Feb 5, 2024
* [Rule Tuning] Windows BBR Tuning - 1 * . --------- Co-authored-by: Samirbous <[email protected]> (cherry picked from commit 8274f9a)
protectionsmachine
pushed a commit
that referenced
this pull request
Feb 5, 2024
* [Rule Tuning] Windows BBR Tuning - 1 * . --------- Co-authored-by: Samirbous <[email protected]> (cherry picked from commit 8274f9a)
protectionsmachine
pushed a commit
that referenced
this pull request
Feb 5, 2024
* [Rule Tuning] Windows BBR Tuning - 1 * . --------- Co-authored-by: Samirbous <[email protected]> (cherry picked from commit 8274f9a)
protectionsmachine
pushed a commit
that referenced
this pull request
Feb 5, 2024
* [Rule Tuning] Windows BBR Tuning - 1 * . --------- Co-authored-by: Samirbous <[email protected]> (cherry picked from commit 8274f9a)
protectionsmachine
pushed a commit
that referenced
this pull request
Feb 5, 2024
* [Rule Tuning] Windows BBR Tuning - 1 * . --------- Co-authored-by: Samirbous <[email protected]> (cherry picked from commit 8274f9a)
protectionsmachine
pushed a commit
that referenced
this pull request
Feb 5, 2024
* [Rule Tuning] Windows BBR Tuning - 1 * . --------- Co-authored-by: Samirbous <[email protected]> (cherry picked from commit 8274f9a)
protectionsmachine
pushed a commit
that referenced
this pull request
Feb 5, 2024
* [Rule Tuning] Windows BBR Tuning - 1 * . --------- Co-authored-by: Samirbous <[email protected]> (cherry picked from commit 8274f9a)
protectionsmachine
pushed a commit
that referenced
this pull request
Feb 5, 2024
* [Rule Tuning] Windows BBR Tuning - 1 * . --------- Co-authored-by: Samirbous <[email protected]> (cherry picked from commit 8274f9a)
protectionsmachine
pushed a commit
that referenced
this pull request
Feb 5, 2024
* [Rule Tuning] Windows BBR Tuning - 1 * . --------- Co-authored-by: Samirbous <[email protected]> (cherry picked from commit 8274f9a)
protectionsmachine
pushed a commit
that referenced
this pull request
Feb 5, 2024
* [Rule Tuning] Windows BBR Tuning - 1 * . --------- Co-authored-by: Samirbous <[email protected]> (cherry picked from commit 8274f9a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Part of #3186
Summary
Tunes the following rules:
Promotes the following to normal DRs: