Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ATT&CK subtechniques to the schema #337

Merged
merged 12 commits into from
Dec 8, 2020

Conversation

rw-access
Copy link
Contributor

@rw-access rw-access commented Sep 24, 2020

Issues

Part of #215
Related/blocked by elastic/kibana#75771
Related/blocked by elastic/kibana#83511
Related to #614

Summary

Added ATT&CK subtechniques to the schema validation, and drop the field when downgrading from 7.10 to previous versions when the field wasn't available. I haven't added any CLI support yet. I'm not sure how we want to navigate that, especially when we allow multiple tactics in a single threat mapping.

Copy link
Contributor

@brokensound77 brokensound77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rw-access rw-access removed the v7.10.0 label Sep 30, 2020
@brokensound77
Copy link
Contributor

Looks like it merged in Kibana 🎉

Copy link
Contributor

@devonakerr devonakerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rw-access
Copy link
Contributor Author

@brokensound77 I think I assumed multiple tactics would also be fixed in the same PR. so I need to do some double checking before we merge

@rw-access rw-access added the python Internal python for the repository label Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request metadata python Internal python for the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants