-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rule Tuning] Windows DR Tuning - 6 #3246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w0rk3r
added
Rule: Tuning
tweaking or tuning an existing rule
OS: Windows
windows related rules
Domain: Endpoint
backport: auto
labels
Oct 26, 2023
w0rk3r
requested review from
brokensound77,
DefSecSentinel,
imays11,
Samirbous,
Aegrah and
terrancedejesus
October 26, 2023 18:23
w0rk3r
commented
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments to make the review easier
rules/windows/defense_evasion_masquerading_as_elastic_endpoint_process.toml
Show resolved
Hide resolved
rules/windows/defense_evasion_network_connection_from_windows_binary.toml
Outdated
Show resolved
Hide resolved
This was referenced Oct 27, 2023
Aegrah
approved these changes
Oct 27, 2023
shashank-elastic
approved these changes
Oct 27, 2023
terrancedejesus
approved these changes
Dec 8, 2023
@w0rk3r - Still updating repository if we can wait for this until afterwards. |
@terrancedejesus thanks for the ping, I still have some testing/adjusts to do on this one before merge |
protectionsmachine
pushed a commit
that referenced
this pull request
Dec 12, 2023
* [Rule Tuning] Windows DR Tuning - 6 * Update defense_evasion_masquerading_as_elastic_endpoint_process.toml * Update defense_evasion_network_connection_from_windows_binary.toml --------- Co-authored-by: Colson Wilhoit <[email protected]> (cherry picked from commit 6f4c323)
protectionsmachine
pushed a commit
that referenced
this pull request
Dec 12, 2023
* [Rule Tuning] Windows DR Tuning - 6 * Update defense_evasion_masquerading_as_elastic_endpoint_process.toml * Update defense_evasion_network_connection_from_windows_binary.toml --------- Co-authored-by: Colson Wilhoit <[email protected]> (cherry picked from commit 6f4c323)
protectionsmachine
pushed a commit
that referenced
this pull request
Dec 12, 2023
* [Rule Tuning] Windows DR Tuning - 6 * Update defense_evasion_masquerading_as_elastic_endpoint_process.toml * Update defense_evasion_network_connection_from_windows_binary.toml --------- Co-authored-by: Colson Wilhoit <[email protected]> (cherry picked from commit 6f4c323)
protectionsmachine
pushed a commit
that referenced
this pull request
Dec 12, 2023
* [Rule Tuning] Windows DR Tuning - 6 * Update defense_evasion_masquerading_as_elastic_endpoint_process.toml * Update defense_evasion_network_connection_from_windows_binary.toml --------- Co-authored-by: Colson Wilhoit <[email protected]> (cherry picked from commit 6f4c323)
protectionsmachine
pushed a commit
that referenced
this pull request
Dec 12, 2023
* [Rule Tuning] Windows DR Tuning - 6 * Update defense_evasion_masquerading_as_elastic_endpoint_process.toml * Update defense_evasion_network_connection_from_windows_binary.toml --------- Co-authored-by: Colson Wilhoit <[email protected]> (cherry picked from commit 6f4c323)
protectionsmachine
pushed a commit
that referenced
this pull request
Dec 12, 2023
* [Rule Tuning] Windows DR Tuning - 6 * Update defense_evasion_masquerading_as_elastic_endpoint_process.toml * Update defense_evasion_network_connection_from_windows_binary.toml --------- Co-authored-by: Colson Wilhoit <[email protected]> (cherry picked from commit 6f4c323)
protectionsmachine
pushed a commit
that referenced
this pull request
Dec 12, 2023
* [Rule Tuning] Windows DR Tuning - 6 * Update defense_evasion_masquerading_as_elastic_endpoint_process.toml * Update defense_evasion_network_connection_from_windows_binary.toml --------- Co-authored-by: Colson Wilhoit <[email protected]> (cherry picked from commit 6f4c323)
protectionsmachine
pushed a commit
that referenced
this pull request
Dec 12, 2023
* [Rule Tuning] Windows DR Tuning - 6 * Update defense_evasion_masquerading_as_elastic_endpoint_process.toml * Update defense_evasion_network_connection_from_windows_binary.toml --------- Co-authored-by: Colson Wilhoit <[email protected]> (cherry picked from commit 6f4c323)
protectionsmachine
pushed a commit
that referenced
this pull request
Dec 12, 2023
* [Rule Tuning] Windows DR Tuning - 6 * Update defense_evasion_masquerading_as_elastic_endpoint_process.toml * Update defense_evasion_network_connection_from_windows_binary.toml --------- Co-authored-by: Colson Wilhoit <[email protected]> (cherry picked from commit 6f4c323)
protectionsmachine
pushed a commit
that referenced
this pull request
Dec 12, 2023
* [Rule Tuning] Windows DR Tuning - 6 * Update defense_evasion_masquerading_as_elastic_endpoint_process.toml * Update defense_evasion_network_connection_from_windows_binary.toml --------- Co-authored-by: Colson Wilhoit <[email protected]> (cherry picked from commit 6f4c323)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport: auto
Domain: Endpoint
OS: Windows
windows related rules
Rule: Tuning
tweaking or tuning an existing rule
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Part of #3186
Resolves #3104
Summary
Tunes the following rules:
Deletes (instead of deprecating as these never went into any releases) the following development rules that aren't relevant as they are duplicates of production rules: