Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Rules] UEBA GItHub BBRs and Rules #3174
[New Rules] UEBA GItHub BBRs and Rules #3174
Changes from 32 commits
5cf514a
217c5ae
3b38def
d3bb722
2f1653d
2f6cca2
b9534ec
238a6a7
ffa4d17
de5fb96
d359004
b875a1b
9d7db63
d964d95
92df336
1cddd32
b38c279
b5cfd30
421ffef
e9f5bbb
5893a72
cde9081
d4a88c6
f97c6ea
d6032d1
099e65f
826137c
5f58a4d
8d57cfd
9590630
a173f8d
b0a2415
e16f7d2
ff74386
0c032e7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd caution on using tags as part of detection logic. The tags use a specific format that is custom to TRaDE whereas upstream there is no standardization requirements. As a result, we are assuming that prebuilt or custom rules HAVE to have these tags.
As a possible alternative, the alert schema does carry
event.dataset
in documents within the.alerts-security.*
data view or index patterns. As a result, we can search in alert documents forevent.dataset:github
and find the same documents.event.dataset
is in ECS, therefore we are safe to assume this will be consistent.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@terrancedejesus what would you suggest for the "Use Case: UEBA" tag that distinguishes which rules should be part of the threshold?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes @terrancedejesus this is something we have also explored. We ended up settling (for now) on leveraging the UEBA tag in conjunction with either another tag or with (as you mention) an
event.dataset
value. There are for now as far as we know no other reliable methods of applying this filter. Unless we add a specific new field to the rule, a boolean for whether or not a rule is part of a UEBA pack.